[GitHub] [arrow] rok commented on pull request #11944: ARROW-14510: [R] [CI] ensure that docker runs don't use host-built artifacts

[GitBox <gi...@apache.org>]

rok commented on pull request #11944:
URL: https://github.com/apache/arrow/pull/11944#issuecomment-993646080


   > Re: `${R_BIN} CMD INSTALL --clean ${INSTALL_ARGS}` That _should_ solve the problem (though reading [WRE](https://cran.r-project.org/doc/manuals/r-release/R-exts.html#Configure-and-cleanup) it was't 100% clear if the `./cleanup` file needed to be up to date with all the files that needed to be removed (in which case it could still fail if it's not up to date for some reason) or if `--clean` would do that on it's own). But more importantly: that would remove the built artifacts from the directory which might force a re-compile elsewhere. This fix intentionally tried to _not_ impact the shared directory between docker and the host so that if the developer relies on keeping the artifacts around between builds, those will not be overwritten or deleted.
   
   Got it! That makes sense, thanks for the explanation :).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org