Re: svn commit: r1079780 - in /cxf/trunk: api/src/main/java/org/apache/cxf/tools/common/ maven-plugins/codegen-plugin/src/main/java/org/apache/cxf/maven_plugin/ tools/wsdlto/core/src/main/java/org/apache/cxf/tools/wsdlto/ tools/wsdlto/frontend/jaxws/src/ma...

[Willem Jiang <wi...@gmail.com>]

Hi Dan,

Yes, we don't need to use the -gt true option.
I will refactor the command as you suggested.

Thanks,

Willem
On 3/9/11 10:54 PM, Daniel Kulp wrote:
>
>
> I think for a boolean argument like this, it would make a lot more sense to
> not have it be a parameter thing.   I personally think the ONLY time anyone
> would use this would be with  the false parameter, like "-gt false".   No one
> would ever really use -gt true as that's the default.
>
> Thus, my suggestion would be to change it to just:
>
> <option id="notypes" maxOccurs="1">
>        <annotation>Turns off generating types</annotation>
>        <switch>notypes</switch>
> </option>
>
> You can then just use the context.optionSet(...) method to see if the user
> specified it or not.
>
>
>
> Dan
>
>
>
> On Wednesday 09 March 2011 7:54:16 AM ningjiang@apache.org wrote:
>> Author: ningjiang
>> Date: Wed Mar  9 12:54:15 2011
>> New Revision: 1079780
>>
>> URL: http://svn.apache.org/viewvc?rev=1079780&view=rev
>> Log:
>> CXF-3385 Add a new option in WSD2Java to skip the generate the type classes
>> from schema
>>
>> Modified:
>>
>> cxf/trunk/api/src/main/java/org/apache/cxf/tools/common/ToolConstants.java
>> cxf/trunk/maven-plugins/codegen-plugin/src/main/java/org/apache/cxf/maven_
>> plugin/Option.java
>> cxf/trunk/maven-plugins/codegen-plugin/src/main/java/org/apache/cxf/maven_
>> plugin/WsdlOption.java
>> cxf/trunk/tools/wsdlto/core/src/main/java/org/apache/cxf/tools/wsdlto/WSDL
>> ToJavaContainer.java
>> cxf/trunk/tools/wsdlto/core/src/main/java/org/apache/cxf/tools/wsdlto/wsdl
>> to.xml
>> cxf/trunk/tools/wsdlto/frontend/jaxws/src/main/java/org/apache/cxf/tools/w
>> sdlto/frontend/jaxws/jaxws-toolspec.xml
>> cxf/trunk/tools/wsdlto/test/src/test/java/org/apache/cxf/tools/wsdlto/jaxw
>> s/CodeGenTest.java
>>



-- 
Willem
----------------------------------
FuseSource
Web: http://www.fusesource.com
Blog:    http://willemjiang.blogspot.com (English)
          http://jnn.javaeye.com (Chinese)
Twitter: willemjiang