You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by le...@apache.org on 2022/05/15 08:34:33 UTC

svn commit: r1900914 - in /pdfbox/trunk/fontbox/src/test/java/org/apache/fontbox/cff: DataInputRandomAccessTest.java DataInputTest.java

Author: lehmi
Date: Sun May 15 08:34:32 2022
New Revision: 1900914

URL: http://svn.apache.org/viewvc?rev=1900914&view=rev
Log:
PDFBOX-5143: sonar fix

Modified:
    pdfbox/trunk/fontbox/src/test/java/org/apache/fontbox/cff/DataInputRandomAccessTest.java
    pdfbox/trunk/fontbox/src/test/java/org/apache/fontbox/cff/DataInputTest.java

Modified: pdfbox/trunk/fontbox/src/test/java/org/apache/fontbox/cff/DataInputRandomAccessTest.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/fontbox/src/test/java/org/apache/fontbox/cff/DataInputRandomAccessTest.java?rev=1900914&r1=1900913&r2=1900914&view=diff
==============================================================================
--- pdfbox/trunk/fontbox/src/test/java/org/apache/fontbox/cff/DataInputRandomAccessTest.java (original)
+++ pdfbox/trunk/fontbox/src/test/java/org/apache/fontbox/cff/DataInputRandomAccessTest.java Sun May 15 08:34:32 2022
@@ -79,7 +79,8 @@ class DataInputRandomAccessTest
         assertEquals(10, dataInput.length());
         assertTrue(dataInput.hasRemaining());
         assertThrows(IOException.class, () -> dataInput.setPosition(-1));
-        assertThrows(IOException.class, () -> dataInput.setPosition(dataInput.length()));
+        int length = dataInput.length();
+        assertThrows(IOException.class, () -> dataInput.setPosition(length));
     }
 
     @Test
@@ -90,7 +91,8 @@ class DataInputRandomAccessTest
         assertEquals(0, dataInput.peekUnsignedByte(0));
         assertEquals(251, dataInput.peekUnsignedByte(5));
         assertThrows(IOException.class, () -> dataInput.peekUnsignedByte(-1));
-        assertThrows(IOException.class, () -> dataInput.peekUnsignedByte(dataInput.length()));
+        int length = dataInput.length();
+        assertThrows(IOException.class, () -> dataInput.peekUnsignedByte(length));
     }
 
     @Test

Modified: pdfbox/trunk/fontbox/src/test/java/org/apache/fontbox/cff/DataInputTest.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/fontbox/src/test/java/org/apache/fontbox/cff/DataInputTest.java?rev=1900914&r1=1900913&r2=1900914&view=diff
==============================================================================
--- pdfbox/trunk/fontbox/src/test/java/org/apache/fontbox/cff/DataInputTest.java (original)
+++ pdfbox/trunk/fontbox/src/test/java/org/apache/fontbox/cff/DataInputTest.java Sun May 15 08:34:32 2022
@@ -78,7 +78,8 @@ class DataInputTest
         assertEquals(10, dataInput.length());
         assertTrue(dataInput.hasRemaining());
         assertThrows(IOException.class, () -> dataInput.setPosition(-1));
-        assertThrows(IOException.class, () -> dataInput.setPosition(dataInput.length()));
+        int length = dataInput.length();
+        assertThrows(IOException.class, () -> dataInput.setPosition(length));
     }
 
     @Test
@@ -89,7 +90,8 @@ class DataInputTest
         assertEquals(0, dataInput.peekUnsignedByte(0));
         assertEquals(251, dataInput.peekUnsignedByte(5));
         assertThrows(IOException.class, () -> dataInput.peekUnsignedByte(-1));
-        assertThrows(IOException.class, () -> dataInput.peekUnsignedByte(dataInput.length()));
+        int length = dataInput.length();
+        assertThrows(IOException.class, () -> dataInput.peekUnsignedByte(length));
     }
 
     @Test