Re: Review Request: SQOOP-410: Direct modes can't import views

[Abhijeet Gaikwad <ab...@gmail.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6243/#review9690
-----------------------------------------------------------


I have few comments as below.


/src/docs/user/compatibility.txt
<https://reviews.apache.org/r/6243/#comment20658>

    The explanation is vague, either we should explain more or not mention about mysqldump - as user is not expected to know the Sqoop internals. I'm fine if only the issue is mentioned here and not the dev explanation. Let me know.
    
    Just in case you decide to explain, FYI -
    Sqoop parses the INSERT statements dumped by mysqldump utility to extract the data. In case of views the INSERT statements are not dumped, so no data retrieved by Sqoop. In conclusion, mysqldump supports views, just that data is not retrieved for views.



/src/docs/user/compatibility.txt
<https://reviews.apache.org/r/6243/#comment20659>

    Change to:
    "Sqoop supports JDBC-based connector for PostgreSQL.
    JDBC Driver: <link_to_jdbc_driver>
    The connector is tested using <posgresql_jdbc_driver_jar_with_version> with PostgreSQL server 9.1."
    
    Please add if you have any suggestions to this.



/src/docs/user/compatibility.txt
<https://reviews.apache.org/r/6243/#comment20660>

    Can you please add either some more explanation/references for the issue here, or as said earlier am fine if the issue is just mentioned. Let me know.


- Abhijeet Gaikwad


On July 31, 2012, 5:29 p.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6243/
> -----------------------------------------------------------
> 
> (Updated July 31, 2012, 5:29 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> I've documented unsupported import of views in direct modes for MySQL and PostgreSQL databases.
> 
> 
> This addresses bug SQOOP-410.
>     https://issues.apache.org/jira/browse/SQOOP-410
> 
> 
> Diffs
> -----
> 
>   /src/docs/user/compatibility.txt 1367605 
> 
> Diff: https://reviews.apache.org/r/6243/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>