You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2018/08/14 08:50:48 UTC

[GitHub] ashb edited a comment on issue #3722: [AIRFLOW-2759] Add changes to extract proxy details at the base hook …

ashb edited a comment on issue #3722: [AIRFLOW-2759] Add changes to extract proxy details at the base hook …
URL: https://github.com/apache/incubator-airflow/pull/3722#issuecomment-412797224
 
 
   Please address this point:
   
   > As Ravi mentioned on the Jira: it looks like httplib2 can use HTTP_PROXY and HTTPS_PROXY environment variables to set a proxy so it's probably best to just do that
   
   This PR is a lot of code for something that appears built-in, and I'm minded to reject this PR unless you can demonstrate a good reason why this code is needed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services