You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/04/24 21:19:13 UTC

[GitHub] [pulsar-helm-chart] nickelozz opened a new issue #6: Decouple credentials from key secrets generation

nickelozz opened a new issue #6:
URL: https://github.com/apache/pulsar-helm-chart/issues/6

**Is your feature request related to a problem? Please describe.**

As suggested here: https://pulsar.apache.org/docs/en/helm-deploy/#prepare-the-helm-release. The ```prepare_helm_release.sh``` script provided with this Helm chart can create a secret credentials resource and
> The username and password are used for logging into Grafana dashboard and Pulsar Manager.

However, I haven't been able to make use of such a feature for a number of reasons:

1. This secret doesn't seem to affect the ```pulsar-manager-deployment.yaml``` definition. Instead, the ```./templates/pulsar-manager-admin-secret.yaml``` seems to be the one providing the credentials for the pulsar manager (UI) (with the added possibility to override via values.yaml at ```pulsar_manager.admin.user/password```).

2. Using the Pulsar chart as a dependency for an umbrella chart (this is currently my use case), will bring extra hassle that will make it very hard to have all resources follow the same naming structure, thus causing some resources to never be deployed successfully e.g.: ```./templates/grafana-deployment.yaml``` will complain that it couldn't find the secret created by the bash script. Attempting to fix this issue via the ```-k``` flag passed to the script will cause the JWT secret tokens to have a name that's unexpected by the broker, etc.

**Describe the solution you'd like**

The bash script should focus on the JWT secrets creation and nothing else.

The generation of user/password credentials for Grafana and Pulsar Manager should be delegated to individual secret resources that expose such credentials for overriding via ```values.yaml```. This provides flexibility in credentials usage/override on a per-component basis.

Please advise.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-helm-chart] nickelozz commented on issue #6: Decouple credentials from key secrets generation

Posted by GitBox <gi...@apache.org>.

nickelozz commented on issue #6:
URL: https://github.com/apache/pulsar-helm-chart/issues/6#issuecomment-620241702


   Apologies for the delay in replying.
   
   I went ahead and created a [PR](https://github.com/apache/pulsar-helm-chart/pull/7) for this. Please take a look and let me know what you think.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-helm-chart] nickelozz commented on issue #6: Decouple credentials from key secrets generation

Posted by GitBox <gi...@apache.org>.

nickelozz commented on issue #6:
URL: https://github.com/apache/pulsar-helm-chart/issues/6#issuecomment-620718542


   @sijie any news on when this helm chart will be published in the official stable repo?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-helm-chart] sijie commented on issue #6: Decouple credentials from key secrets generation

Posted by GitBox <gi...@apache.org>.

sijie commented on issue #6:
URL: https://github.com/apache/pulsar-helm-chart/issues/6#issuecomment-619782958


   @nickelozz good suggestions. I like the proposal. Are you interested in submitting a pull request for making the changes?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-helm-chart] nickelozz edited a comment on issue #6: Decouple credentials from key secrets generation

Posted by GitBox <gi...@apache.org>.

nickelozz edited a comment on issue #6:
URL: https://github.com/apache/pulsar-helm-chart/issues/6#issuecomment-620718542


   @sijie any news on if/when this helm chart will be published in the official stable repo?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org