[GitHub] [hudi] danny0405 commented on a diff in pull request #5953: [HUDI-4314] Improve the performance of reading from the specified ins…

[GitBox <gi...@apache.org>]

danny0405 commented on code in PR #5953:
URL: https://github.com/apache/hudi/pull/5953#discussion_r912432257


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/source/IncrementalInputSplits.java:
##########
@@ -302,6 +311,32 @@ private Stream<HoodieInstant> maySkipCompaction(Stream<HoodieInstant> instants)
         : instants;
   }
 
+  private Stream<FileSlice> filterFileSliceWithValidFiles(FileSystem fs, Stream<FileSlice> fileSlices) {
+    return fileSlices.filter(fileSlice -> {
+      Option<String> basePath = fileSlice.getBaseFile().map(BaseFile::getPath);
+      try {
+        if (!basePath.isPresent()) {
+          return true;
+        }
+        return fs.exists(new org.apache.hadoop.fs.Path(basePath.get()));
+      } catch (IOException e) {
+        LOG.error("Checking exists of base path: {} error", basePath);
+        throw new HoodieException(e);
+      }

Review Comment:
   The logic is still incorrect, when a file slice has base file that does not exist but the log files exist, we should keep it.
   In other words, we should keep the file slice if any base/log file exists :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org