You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by rm...@apache.org on 2012/08/28 04:19:34 UTC
svn commit: r1377946 - in /lucene/dev/branches/branch_4x: ./ dev-tools/
dev-tools/scripts/checkJavaDocs.py
Author: rmuir
Date: Tue Aug 28 02:19:34 2012
New Revision: 1377946
URL: http://svn.apache.org/viewvc?rev=1377946&view=rev
Log:
don't parse incomplete method specification
Modified:
lucene/dev/branches/branch_4x/ (props changed)
lucene/dev/branches/branch_4x/dev-tools/ (props changed)
lucene/dev/branches/branch_4x/dev-tools/scripts/checkJavaDocs.py
Modified: lucene/dev/branches/branch_4x/dev-tools/scripts/checkJavaDocs.py
URL: http://svn.apache.org/viewvc/lucene/dev/branches/branch_4x/dev-tools/scripts/checkJavaDocs.py?rev=1377946&r1=1377945&r2=1377946&view=diff
==============================================================================
--- lucene/dev/branches/branch_4x/dev-tools/scripts/checkJavaDocs.py (original)
+++ lucene/dev/branches/branch_4x/dev-tools/scripts/checkJavaDocs.py Tue Aug 28 02:19:34 2012
@@ -22,7 +22,7 @@ reHREF = re.compile('<a.*?>(.*?)</a>', r
reMarkup = re.compile('<.*?>')
reDivBlock = re.compile('<div class="block">(.*?)</div>', re.IGNORECASE)
reCaption = re.compile('<caption><span>(.*?)</span>', re.IGNORECASE)
-reTDLast = re.compile('<td class="colLast">(.*?)$', re.IGNORECASE)
+reTDLast = re.compile('<td class="colLast">.*<a href=".*#(.*?)">', re.IGNORECASE)
reColOne = re.compile('<td class="colOne">(.*?)</td>', re.IGNORECASE)
def cleanHTML(s):
@@ -52,8 +52,10 @@ def checkClass(fullPath):
#print(' caption %s' % lastCaption)
m = reTDLast.search(line)
if m is not None:
- # TODO: this will only get the first line of multi-line things:
- lastItem = cleanHTML(m.group(1))
+ # TODO: this is actually the link anchor for the method, which we must
+ # somehow defer and only later check if the list at that anchor does not contain
+ # the text 'specified by' (in which case its an overridden method from an external library)
+ lastItem = m.group(1)
#print(' item %s' % lastItem)
else:
m = reColOne.search(line)