You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Brenden Matthews <br...@diddyinc.com> on 2013/09/17 00:09:25 UTC
Review Request 14164: Fixed build breakage from 37e946683f1bb6a.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14164/
-----------------------------------------------------------
Review request for mesos.
Bugs: MESOS-688
https://issues.apache.org/jira/browse/MESOS-688
Repository: mesos-git
Description
-------
Fixed build breakage from 37e946683f1bb6a.
In 37e946683f1bb6a I fixed a build failure from a warning, which are
treated as errors.
Newer versions of GCC have a feature (documented here:
http://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html) where unknown
warning flags are ignored.
In older version of GCC (such as 4.1 or 4.2), it appears that these flags
aren't ignored, resulting in an error.
Review: https://reviews.apache.org/r/14164
Diffs
-----
configure.ac 73baf034972549ff34ac1c8f7c098fb3a34baf4e
Diff: https://reviews.apache.org/r/14164/diff/
Testing
-------
make check
Thanks,
Brenden Matthews
Re: Review Request 14164: Fixed build breakage from 37e946683f1bb6a.
Posted by Brenden Matthews <br...@diddyinc.com>.
> On Sept. 17, 2013, 12:55 a.m., Vinod Kone wrote:
> > configure.ac, line 217
> > <https://reviews.apache.org/r/14164/diff/1/?file=352499#file352499line217>
> >
> > This is missing a ";;" here.
>
> Vinod Kone wrote:
> Also confirmed that the patch works with gcc 4.2 on osx and linux (after the semicolons fix ofcourse :)).
Weird. The missing semicolons fell off the face of the earth: https://github.com/airbnb/mesos/commit/3adfe752cc7b9798c5ae52edb2d38fec24d82ae1#L0R225
- Brenden
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14164/#review26161
-----------------------------------------------------------
On Sept. 16, 2013, 10:09 p.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14164/
> -----------------------------------------------------------
>
> (Updated Sept. 16, 2013, 10:09 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-688
> https://issues.apache.org/jira/browse/MESOS-688
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fixed build breakage from 37e946683f1bb6a.
>
> In 37e946683f1bb6a I fixed a build failure from a warning, which are
> treated as errors.
>
> Newer versions of GCC have a feature (documented here:
> http://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html) where unknown
> warning flags are ignored.
>
> In older version of GCC (such as 4.1 or 4.2), it appears that these flags
> aren't ignored, resulting in an error.
>
> Review: https://reviews.apache.org/r/14164
>
>
> Diffs
> -----
>
> configure.ac 73baf034972549ff34ac1c8f7c098fb3a34baf4e
>
> Diff: https://reviews.apache.org/r/14164/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Brenden Matthews
>
>
Re: Review Request 14164: Fixed build breakage from 37e946683f1bb6a.
Posted by Vinod Kone <vi...@gmail.com>.
> On Sept. 17, 2013, 12:55 a.m., Vinod Kone wrote:
> > configure.ac, line 217
> > <https://reviews.apache.org/r/14164/diff/1/?file=352499#file352499line217>
> >
> > This is missing a ";;" here.
Also confirmed that the patch works with gcc 4.2 on osx and linux (after the semicolons fix ofcourse :)).
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14164/#review26161
-----------------------------------------------------------
On Sept. 16, 2013, 10:09 p.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14164/
> -----------------------------------------------------------
>
> (Updated Sept. 16, 2013, 10:09 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-688
> https://issues.apache.org/jira/browse/MESOS-688
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fixed build breakage from 37e946683f1bb6a.
>
> In 37e946683f1bb6a I fixed a build failure from a warning, which are
> treated as errors.
>
> Newer versions of GCC have a feature (documented here:
> http://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html) where unknown
> warning flags are ignored.
>
> In older version of GCC (such as 4.1 or 4.2), it appears that these flags
> aren't ignored, resulting in an error.
>
> Review: https://reviews.apache.org/r/14164
>
>
> Diffs
> -----
>
> configure.ac 73baf034972549ff34ac1c8f7c098fb3a34baf4e
>
> Diff: https://reviews.apache.org/r/14164/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Brenden Matthews
>
>
Re: Review Request 14164: Fixed build breakage from 37e946683f1bb6a.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14164/#review26161
-----------------------------------------------------------
configure.ac
<https://reviews.apache.org/r/14164/#comment51119>
This is missing a ";;" here.
configure.ac
<https://reviews.apache.org/r/14164/#comment51120>
s/remove/Remove/
- Vinod Kone
On Sept. 16, 2013, 10:09 p.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14164/
> -----------------------------------------------------------
>
> (Updated Sept. 16, 2013, 10:09 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-688
> https://issues.apache.org/jira/browse/MESOS-688
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fixed build breakage from 37e946683f1bb6a.
>
> In 37e946683f1bb6a I fixed a build failure from a warning, which are
> treated as errors.
>
> Newer versions of GCC have a feature (documented here:
> http://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html) where unknown
> warning flags are ignored.
>
> In older version of GCC (such as 4.1 or 4.2), it appears that these flags
> aren't ignored, resulting in an error.
>
> Review: https://reviews.apache.org/r/14164
>
>
> Diffs
> -----
>
> configure.ac 73baf034972549ff34ac1c8f7c098fb3a34baf4e
>
> Diff: https://reviews.apache.org/r/14164/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Brenden Matthews
>
>
Re: Review Request 14164: Fixed build breakage from 37e946683f1bb6a.
Posted by Brenden Matthews <br...@diddyinc.com>.
> On Sept. 17, 2013, 3:48 a.m., Vinod Kone wrote:
> > Ship It!
I can't commit this right now. If it can't wait until the morning, I'll need somebody to do it for me.
- Brenden
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14164/#review26166
-----------------------------------------------------------
On Sept. 17, 2013, 3:10 a.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14164/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2013, 3:10 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-688
> https://issues.apache.org/jira/browse/MESOS-688
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fixed build breakage from 37e946683f1bb6a.
>
> In 37e946683f1bb6a I fixed a build failure from a warning, which are
> treated as errors.
>
> Newer versions of GCC have a feature (documented here:
> http://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html) where unknown
> warning flags are ignored.
>
> In older version of GCC (such as 4.1 or 4.2), it appears that these flags
> aren't ignored, resulting in an error.
>
> Review: https://reviews.apache.org/r/14164
>
>
> Diffs
> -----
>
> configure.ac 73baf034972549ff34ac1c8f7c098fb3a34baf4e
>
> Diff: https://reviews.apache.org/r/14164/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Brenden Matthews
>
>
Re: Review Request 14164: Fixed build breakage from 37e946683f1bb6a.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14164/#review26166
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Sept. 17, 2013, 3:10 a.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14164/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2013, 3:10 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-688
> https://issues.apache.org/jira/browse/MESOS-688
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fixed build breakage from 37e946683f1bb6a.
>
> In 37e946683f1bb6a I fixed a build failure from a warning, which are
> treated as errors.
>
> Newer versions of GCC have a feature (documented here:
> http://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html) where unknown
> warning flags are ignored.
>
> In older version of GCC (such as 4.1 or 4.2), it appears that these flags
> aren't ignored, resulting in an error.
>
> Review: https://reviews.apache.org/r/14164
>
>
> Diffs
> -----
>
> configure.ac 73baf034972549ff34ac1c8f7c098fb3a34baf4e
>
> Diff: https://reviews.apache.org/r/14164/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Brenden Matthews
>
>
Re: Review Request 14164: Fixed build breakage from 37e946683f1bb6a.
Posted by Brenden Matthews <br...@diddyinc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14164/
-----------------------------------------------------------
(Updated Sept. 17, 2013, 3:10 a.m.)
Review request for mesos.
Changes
-------
Updated as per Vinod's comments.
Bugs: MESOS-688
https://issues.apache.org/jira/browse/MESOS-688
Repository: mesos-git
Description
-------
Fixed build breakage from 37e946683f1bb6a.
In 37e946683f1bb6a I fixed a build failure from a warning, which are
treated as errors.
Newer versions of GCC have a feature (documented here:
http://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html) where unknown
warning flags are ignored.
In older version of GCC (such as 4.1 or 4.2), it appears that these flags
aren't ignored, resulting in an error.
Review: https://reviews.apache.org/r/14164
Diffs (updated)
-----
configure.ac 73baf034972549ff34ac1c8f7c098fb3a34baf4e
Diff: https://reviews.apache.org/r/14164/diff/
Testing
-------
make check
Thanks,
Brenden Matthews