You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2019/03/22 06:19:37 UTC
Re: Review Request 70217: Cleanup volume creation,
validation and deletion for SLRP.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70217/
-----------------------------------------------------------
(Updated March 22, 2019, 6:19 a.m.)
Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
Changes
-------
Restructured the refactoring.
Summary (updated)
-----------------
Cleanup volume creation, validation and deletion for SLRP.
Bugs: MESOS-9622
https://issues.apache.org/jira/browse/MESOS-9622
Repository: mesos
Description (updated)
-------
This patch introduces methods for volume creation, validation and
deletion that conform to `VolumeManager`'s public interface in SLRP, and
cleans up SLRP based on these functions. They will be moved out from
SLRP to v0 `VolumeManager` later.
Specifically, volume deletion now supports deleting untracked volumes.
Diffs (updated)
-----
src/resource_provider/storage/provider.cpp fea623c292158deb1b4b4b9ab1ac208031471519
src/resource_provider/storage/provider_process.hpp a5536b3d735e01eb1c4dc52d0602d973155f3c93
Diff: https://reviews.apache.org/r/70217/diff/4/
Changes: https://reviews.apache.org/r/70217/diff/3-4/
Testing
-------
make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 70217: Cleanup volume creation,
validation and deletion for SLRP.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70217/#review213994
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Bannier
On March 23, 2019, 12:33 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70217/
> -----------------------------------------------------------
>
> (Updated March 23, 2019, 12:33 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-9622
> https://issues.apache.org/jira/browse/MESOS-9622
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch introduces methods for volume creation, validation and
> deletion that conform to `VolumeManager`'s public interface in SLRP, and
> cleans up SLRP based on these functions. They will be moved out from
> SLRP to v0 `VolumeManager` later.
>
> Specifically, volume deletion now supports deleting untracked volumes.
>
>
> Diffs
> -----
>
> src/resource_provider/storage/provider.cpp fea623c292158deb1b4b4b9ab1ac208031471519
> src/resource_provider/storage/provider_process.hpp a5536b3d735e01eb1c4dc52d0602d973155f3c93
>
>
> Diff: https://reviews.apache.org/r/70217/diff/5/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70217: Cleanup volume creation,
validation and deletion for SLRP.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70217/
-----------------------------------------------------------
(Updated March 28, 2019, 7:57 a.m.)
Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
Changes
-------
Rebased.
Bugs: MESOS-9622
https://issues.apache.org/jira/browse/MESOS-9622
Repository: mesos
Description
-------
This patch introduces methods for volume creation, validation and
deletion that conform to `VolumeManager`'s public interface in SLRP, and
cleans up SLRP based on these functions. They will be moved out from
SLRP to v0 `VolumeManager` later.
Specifically, volume deletion now supports deleting untracked volumes.
Diffs (updated)
-----
src/resource_provider/storage/provider.cpp 2711503cdb58cb9b34af8c9fad0908c5f788a2af
src/resource_provider/storage/provider_process.hpp a5536b3d735e01eb1c4dc52d0602d973155f3c93
Diff: https://reviews.apache.org/r/70217/diff/7/
Changes: https://reviews.apache.org/r/70217/diff/6-7/
Testing
-------
make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 70217: Cleanup volume creation,
validation and deletion for SLRP.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70217/
-----------------------------------------------------------
(Updated March 27, 2019, 5:58 a.m.)
Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
Changes
-------
Rebased.
Bugs: MESOS-9622
https://issues.apache.org/jira/browse/MESOS-9622
Repository: mesos
Description
-------
This patch introduces methods for volume creation, validation and
deletion that conform to `VolumeManager`'s public interface in SLRP, and
cleans up SLRP based on these functions. They will be moved out from
SLRP to v0 `VolumeManager` later.
Specifically, volume deletion now supports deleting untracked volumes.
Diffs (updated)
-----
src/resource_provider/storage/provider.cpp 2711503cdb58cb9b34af8c9fad0908c5f788a2af
src/resource_provider/storage/provider_process.hpp a5536b3d735e01eb1c4dc52d0602d973155f3c93
Diff: https://reviews.apache.org/r/70217/diff/6/
Changes: https://reviews.apache.org/r/70217/diff/5-6/
Testing
-------
make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 70217: Cleanup volume creation,
validation and deletion for SLRP.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70217/
-----------------------------------------------------------
(Updated March 22, 2019, 11:33 p.m.)
Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
Changes
-------
Fixed some bad logging/error messages.
Bugs: MESOS-9622
https://issues.apache.org/jira/browse/MESOS-9622
Repository: mesos
Description
-------
This patch introduces methods for volume creation, validation and
deletion that conform to `VolumeManager`'s public interface in SLRP, and
cleans up SLRP based on these functions. They will be moved out from
SLRP to v0 `VolumeManager` later.
Specifically, volume deletion now supports deleting untracked volumes.
Diffs (updated)
-----
src/resource_provider/storage/provider.cpp fea623c292158deb1b4b4b9ab1ac208031471519
src/resource_provider/storage/provider_process.hpp a5536b3d735e01eb1c4dc52d0602d973155f3c93
Diff: https://reviews.apache.org/r/70217/diff/5/
Changes: https://reviews.apache.org/r/70217/diff/4-5/
Testing
-------
make check
Thanks,
Chun-Hung Hsiao