[GitHub] [geode] pivotal-jbarrett commented on a change in pull request #7346: GEODE-9982: Pin server version to 1.14 for 1.0.0 and older clients.

[GitBox <gi...@apache.org>]

pivotal-jbarrett commented on a change in pull request #7346:
URL: https://github.com/apache/geode/pull/7346#discussion_r801174255



##########
File path: geode-membership/src/main/java/org/apache/geode/distributed/internal/membership/gms/MemberIdentifierImpl.java
##########
@@ -676,7 +675,14 @@ public void toDataPre_GFE_9_0_0_0(DataOutput out, SerializationContext context)
         durableId == null ? 300 : memberData.getDurableTimeout(),
         out);
 
-    short version = memberData.getVersionOrdinal();
+    final short version;
+    if (context.getSerializationVersion().isNewerThan(KnownVersion.GFE_90)) {
+      version = memberData.getVersionOrdinal();
+    } else {
+      // This version of geode-native could not parse the longer version ordinals.
+      // Let's make these older clients think the server is still 1.14.
+      version = KnownVersion.GEODE_1_14_0.ordinal();

Review comment:
       This code will only be in 1.15+, so 1.14.0 will always be the older.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org