You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/07/09 19:34:22 UTC
[GitHub] [kafka] mumrah opened a new pull request #11012: Add KRaft "broker" to several RPC's listeners
mumrah opened a new pull request #11012:
URL: https://github.com/apache/kafka/pull/11012
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji commented on a change in pull request #11012: Add KRaft "broker" to several RPC's listeners
Posted by GitBox <gi...@apache.org>.
hachikuji commented on a change in pull request #11012:
URL: https://github.com/apache/kafka/pull/11012#discussion_r667212406
##########
File path: clients/src/main/resources/common/message/CreatePartitionsRequest.json
##########
@@ -16,7 +16,7 @@
{
"apiKey": 37,
"type": "request",
- "listeners": ["zkBroker"],
+ "listeners": ["zkBroker", "broker"],
Review comment:
Should "controller" be in here also? Same for `ElectLeaders`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji merged pull request #11012: Add KRaft "broker" to several RPC's listeners
Posted by GitBox <gi...@apache.org>.
hachikuji merged pull request #11012:
URL: https://github.com/apache/kafka/pull/11012
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji commented on pull request #11012: Add KRaft "broker" to several RPC's listeners
Posted by GitBox <gi...@apache.org>.
hachikuji commented on pull request #11012:
URL: https://github.com/apache/kafka/pull/11012#issuecomment-877418762
While we're at it, I think we should be able to remove "broker" from the listeners for `AllocateProducerIds`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji commented on pull request #11012: Add KRaft "broker" to several RPC's listeners
Posted by GitBox <gi...@apache.org>.
hachikuji commented on pull request #11012:
URL: https://github.com/apache/kafka/pull/11012#issuecomment-877459197
One more to fix i s`UnregisterBroker`. We do not need this exposed on the broker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji edited a comment on pull request #11012: Add KRaft "broker" to several RPC's listeners
Posted by GitBox <gi...@apache.org>.
hachikuji edited a comment on pull request #11012:
URL: https://github.com/apache/kafka/pull/11012#issuecomment-877459197
One more to fix is `UnregisterBroker`. We do not need this exposed on the broker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org