[GitHub] [daffodil] stevedlawrence opened a new pull request, #1005: Fix min/maxOccurs validation for optional elements

["stevedlawrence (via GitHub)" <gi...@apache.org>]

stevedlawrence opened a new pull request, #1005:
URL: https://github.com/apache/daffodil/pull/1005

   Commit dd60b6067d made changes to validation so that it took into account absent elements that incremented the array iteration count but did not actually change the array size. It did this by just counting the actual elements in the infoset. Unfortunately, that change was very subtly broken for optional elements since it assumed maybeLastChild was always a DIArray, but it could actually be a DISimple/DIComplex for optional elements since they use very similar array logic.
   
   We could modify this logic to take DISimple/DIComplex nodes into account, but later commit 16c738c38f added new state to differentiate between the occurs index and the iteration index. So this just modifies the array validation logic so it is very similar to the old logic, but uses the new state that accounts for absent elements.
   
   DAFFODIL-2808


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [daffodil] stevedlawrence merged pull request #1005: Fix min/maxOccurs validation for optional elements

["stevedlawrence (via GitHub)" <gi...@apache.org>]

stevedlawrence merged PR #1005:
URL: https://github.com/apache/daffodil/pull/1005


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org