You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by to...@apache.org on 2019/08/23 15:41:12 UTC
[libcloud] branch trunk updated (52cd83c -> 39f2841)
This is an automated email from the ASF dual-hosted git repository.
tomaz pushed a change to branch trunk
in repository https://gitbox.apache.org/repos/asf/libcloud.git.
from 52cd83c Merge pull request #1343 from yairshemla/gce_driver_add_missing_cpu_platform_field
new 4365ac9 Add changelog entry for #1343.
new 39f2841 Add test case for change in #1343.
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
CHANGES.rst | 4 ++++
libcloud/test/compute/fixtures/gce/zones_us-central1-a_instances.json | 4 +++-
libcloud/test/compute/test_gce.py | 2 ++
3 files changed, 9 insertions(+), 1 deletion(-)
[libcloud] 01/02: Add changelog entry for #1343.
Posted by to...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
tomaz pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/libcloud.git
commit 4365ac9a8bc01e0cbfbdcb1d7bba1fc8638c5548
Author: Tomaz Muraus <to...@tomaz.me>
AuthorDate: Fri Aug 23 17:33:20 2019 +0200
Add changelog entry for #1343.
---
CHANGES.rst | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/CHANGES.rst b/CHANGES.rst
index 1eccfc1..72787d3 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -178,6 +178,10 @@ Compute
``False``. (GITHUB-1334, GITHUB-1335)
[@r2ronoha]
+- [GCE] Add optional ``cpuPlatform`` and ``minCpuPlatform`` attributes to the
+ ``node.extra`` dictionary. (GITHUB-1342, GITHUB-1343)
+ [@yairshemla]
+
Storage
~~~~~~~
[libcloud] 02/02: Add test case for change in #1343.
Posted by to...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
tomaz pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/libcloud.git
commit 39f2841a33d34a4460b269d02fd4dbff0c5ca5a7
Author: Tomaz Muraus <to...@tomaz.me>
AuthorDate: Fri Aug 23 17:37:21 2019 +0200
Add test case for change in #1343.
---
libcloud/test/compute/fixtures/gce/zones_us-central1-a_instances.json | 4 +++-
libcloud/test/compute/test_gce.py | 2 ++
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/libcloud/test/compute/fixtures/gce/zones_us-central1-a_instances.json b/libcloud/test/compute/fixtures/gce/zones_us-central1-a_instances.json
index 9fccb06..6f89843 100644
--- a/libcloud/test/compute/fixtures/gce/zones_us-central1-a_instances.json
+++ b/libcloud/test/compute/fixtures/gce/zones_us-central1-a_instances.json
@@ -44,6 +44,8 @@
},
"selfLink": "https://www.googleapis.com/compute/v1/projects/project_name/zones/us-central1-a/instances/node-name",
"status": "RUNNING",
+ "cpuPlatform": "Intel Skylake",
+ "minCpuPlatform": "Intel Skylake",
"tags": {
"fingerprint": "42WmSpB8rSM="
},
@@ -52,4 +54,4 @@
],
"kind": "compute#instanceList",
"selfLink": "https://www.googleapis.com/compute/v1/projects/project_name/zones/us-central1-a/instances"
-}
\ No newline at end of file
+}
diff --git a/libcloud/test/compute/test_gce.py b/libcloud/test/compute/test_gce.py
index 7384237..39b9a96 100644
--- a/libcloud/test/compute/test_gce.py
+++ b/libcloud/test/compute/test_gce.py
@@ -640,6 +640,8 @@ class GCENodeDriverTest(GoogleTestCase, TestCaseMixin):
self.assertEqual(len(nodes_uc1a), 1)
self.assertEqual(nodes[0].name, 'node-name')
self.assertEqual(nodes_uc1a[0].name, 'node-name')
+ self.assertEqual(nodes_uc1a[0].extra['cpuPlatform'], 'Intel Skylake')
+ self.assertEqual(nodes_uc1a[0].extra['minCpuPlatform'], 'Intel Skylake')
names = [n.name for n in nodes_all]
self.assertTrue('node-name' in names)