You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "sergiimk (via GitHub)" <gi...@apache.org> on 2023/05/29 22:30:49 UTC

[GitHub] [arrow-rs] sergiimk opened a new pull request, #4309: Treat legacy TIMSETAMP_X converted types as UTC

sergiimk opened a new pull request, #4309:
URL: https://github.com/apache/arrow-rs/pull/4309

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #4308.
   
   # Are there any user-facing changes?
   This will change the behavior for users who read Parquet produced by older systems that still use legacy converted types (e.g. Apache Spark is one of them), but it changes it to be aligned with Parquet spec.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold merged pull request #4309: Treat legacy TIMSETAMP_X converted types as UTC

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #4309:
URL: https://github.com/apache/arrow-rs/pull/4309


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] sergiimk commented on pull request #4309: Treat legacy TIMSETAMP_X converted types as UTC

Posted by "sergiimk (via GitHub)" <gi...@apache.org>.
sergiimk commented on PR #4309:
URL: https://github.com/apache/arrow-rs/pull/4309#issuecomment-1567593358

   Let me know if you think user-facing impact is acceptable and I can try to align the tests with this change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] sergiimk commented on pull request #4309: Treat legacy TIMSETAMP_X converted types as UTC

Posted by "sergiimk (via GitHub)" <gi...@apache.org>.
sergiimk commented on PR #4309:
URL: https://github.com/apache/arrow-rs/pull/4309#issuecomment-1569285105

   Thanks for taking a look @tustvold, I've updated the tests and this PR should be ready for final review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold commented on pull request #4309: Treat legacy TIMSETAMP_X converted types as UTC

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #4309:
URL: https://github.com/apache/arrow-rs/pull/4309#issuecomment-1568260344

   This change seems fine to me, thank you


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold commented on pull request #4309: Treat legacy TIMSETAMP_X converted types as UTC

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #4309:
URL: https://github.com/apache/arrow-rs/pull/4309#issuecomment-1569890430

   I've marked this API change, as whilst the prior behaviour was technically a bug, this will serve to highlight this change in the changelog


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org