[jira] [Commented] (HBASE-13097) Reduce Connection and RpcClient creations in unit tests

["Jurriaan Mous (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-13097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14338476#comment-14338476 ] 

Jurriaan Mous commented on HBASE-13097:
---------------------------------------

Yes it is a valid solution and would make having multiple connections a lot cheaper. I am ok with it.
I think it would be very rare that anyone wants to have different Connections with separate eventLoopGroups with different characteristics. This way it is still possible.

> Reduce Connection and RpcClient creations in unit tests
> -------------------------------------------------------
>
>                 Key: HBASE-13097
>                 URL: https://issues.apache.org/jira/browse/HBASE-13097
>             Project: HBase
>          Issue Type: Bug
>          Components: IPC/RPC, test
>    Affects Versions: 2.0.0, 1.1.0
>            Reporter: zhangduo
>            Assignee: zhangduo
>             Fix For: 2.0.0, 1.1.0
>
>         Attachments: HBASE-13097.patch
>
>
> In some unit tests(such as TestAcidGuarantees) we create multiple Connection instance. If we use AsyncRpcClient, then there will be multiple netty Bootstrap and every Bootstrap has its own PooledByteBufAllocator.
> I haven't read the code clearly but it uses some threadlocal technics and jmap shows io.netty.buffer.PoolThreadCache$MemoryRegionCache$Entry is the biggest things on Heap.
> See https://builds.apache.org/job/HBase-TRUNK/6168/artifact/hbase-server/target/surefire-reports/org.apache.hadoop.hbase.TestAcidGuarantees-output.txt
> {noformat}
> 2015-02-24 23:50:29,704 WARN  [JvmPauseMonitor] util.JvmPauseMonitor$Monitor(167): Detected pause in JVM or host machine (eg GC): pause of approximately 20133ms
> GC pool 'PS MarkSweep' had collection(s): count=15 time=55525ms
> {noformat}
> Update: We use a singleton PooledByteBufAllocator so the reason should be too many threads. So we will work on reduce the connections and rpclients in unit tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)