You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by egorklimov <gi...@git.apache.org> on 2018/08/01 16:39:58 UTC
[GitHub] zeppelin pull request #3107: [ZEPPELIN-3646] Add note for updating user perm...
GitHub user egorklimov opened a pull request:
https://github.com/apache/zeppelin/pull/3107
[ZEPPELIN-3646] Add note for updating user permissions
### What is this PR for?
This is @mebelousov workaround to @maziyarpanahi [problem](https://issues.apache.org/jira/browse/ZEPPELIN-3646) refactored with REST API. It will be helpful for everyone who is upgrading from any version less than 0.8.x
### What type of PR is it?
Improvement
### What is the Jira issue?
issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN-3646
### How should this be tested?
* Tested manually
### Screenshots (if appropriate)
* Note in report view:
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Yes, docs updated
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-3646
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/3107.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3107
----
commit 5c65c45093c62e9058688aafb3363f7fd547e3d3
Author: Egor Klimov <kl...@...>
Date: 2018-08-01T15:17:30Z
Add `Migrate from 0.7`
commit 84f36d0a32df890be5d48cf2dda4ea408cd752e1
Author: egorklimov <kl...@...>
Date: 2018-08-01T15:25:05Z
Docs updated
commit 76e239aff01ffda7414594435f30e7da656edd46
Author: Egor Klimov <kl...@...>
Date: 2018-08-01T16:34:45Z
Note updated
----
---
[GitHub] zeppelin pull request #3107: [ZEPPELIN-3646] Add note for updating user perm...
Posted by egorklimov <gi...@git.apache.org>.
GitHub user egorklimov reopened a pull request:
https://github.com/apache/zeppelin/pull/3107
[ZEPPELIN-3646] Add note for updating user permissions
### What is this PR for?
This is @mebelousov workaround to @maziyarpanahi [problem](https://issues.apache.org/jira/browse/ZEPPELIN-3646) refactored with REST API. It will be helpful for everyone who is upgrading from any version less than 0.8.x
### What type of PR is it?
Improvement
### What is the Jira issue?
issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN-3646
### How should this be tested?
* Tested manually
### Screenshots (if appropriate)
* Note in report view:
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Yes, docs updated
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-3646
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/3107.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3107
----
commit 5c65c45093c62e9058688aafb3363f7fd547e3d3
Author: Egor Klimov <kl...@...>
Date: 2018-08-01T15:17:30Z
Add `Migrate from 0.7`
commit 84f36d0a32df890be5d48cf2dda4ea408cd752e1
Author: egorklimov <kl...@...>
Date: 2018-08-01T15:25:05Z
Docs updated
commit 76e239aff01ffda7414594435f30e7da656edd46
Author: Egor Klimov <kl...@...>
Date: 2018-08-01T16:34:45Z
Note updated
commit 57238e5dc10e73aff534d0b02d44fa2f84b9156e
Author: egorklimov <kl...@...>
Date: 2018-08-02T10:36:39Z
Docs updated
commit 8ac1026d1efcf2de0a357fd8b95af53de55614c2
Author: Egor Klimov <kl...@...>
Date: 2018-08-06T16:26:50Z
Owner info updated
commit c5e0737d45b28807fbedb010dbfb311472fa4f65
Author: Egor Klimov <kl...@...>
Date: 2018-08-06T16:44:31Z
NoteId updated
commit ed0de8e7d631a1f6fc0729ffb327cb32719cdfbb
Author: Egor Klimov <kl...@...>
Date: 2018-08-09T16:59:07Z
move note to docs
commit 71dd4ed4408b2ffe3d6d1d836566ee38387cf682
Author: Egor Klimov <kl...@...>
Date: 2018-08-09T17:18:03Z
Upgrading scenario updated
commit a77414051b17079786ed53f467a9c73717ed75a6
Author: Egor Klimov <kl...@...>
Date: 2018-08-09T17:18:35Z
typo fixed
commit 472e86542efa17729dedb062a51e9cedf8cab9df
Author: Egor Klimov <kl...@...>
Date: 2018-08-10T08:11:40Z
Rat excludes updated
----
---
[GitHub] zeppelin pull request #3107: [ZEPPELIN-3646] Add note for updating user perm...
Posted by egorklimov <gi...@git.apache.org>.
Github user egorklimov closed the pull request at:
https://github.com/apache/zeppelin/pull/3107
---
[GitHub] zeppelin issue #3107: [ZEPPELIN-3646] Add note for updating user permissions
Posted by mebelousov <gi...@git.apache.org>.
Github user mebelousov commented on the issue:
https://github.com/apache/zeppelin/pull/3107
@felixcheung could you point out good place for code that will be helpful after the migration to new version?
---
[GitHub] zeppelin issue #3107: [ZEPPELIN-3646] Add note for updating user permissions
Posted by egorklimov <gi...@git.apache.org>.
Github user egorklimov commented on the issue:
https://github.com/apache/zeppelin/pull/3107
@maziyarpanahi I can offer to put it in `dev` folder, because I don't know the place where it could be added for remote access, maybe @felixcheung could offer a better solution.
---
[GitHub] zeppelin issue #3107: [ZEPPELIN-3646] Add note for updating user permissions
Posted by maziyarpanahi <gi...@git.apache.org>.
Github user maziyarpanahi commented on the issue:
https://github.com/apache/zeppelin/pull/3107
Thanks, the process of using the Note is now manual and the documentation has instructions which are very good. But I still believe we need to give admins the opportunity to fix this offline without starting the Zeppelin server to run the Note. I think having both options is fair to the SysAdmins.
@felixcheung @egorklimov Is there such place to put such script? Is it OK to not ship the script and just put it somewhere in the repo and ask the user to download it?
---
[GitHub] zeppelin issue #3107: [ZEPPELIN-3646] Add note for updating user permissions
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/3107
I think the advantage of having a script separate from demo is that it can be ACL'd properly - user won't have access etc.
---
[GitHub] zeppelin issue #3107: [ZEPPELIN-3646] Add note for updating user permissions
Posted by maziyarpanahi <gi...@git.apache.org>.
Github user maziyarpanahi commented on the issue:
https://github.com/apache/zeppelin/pull/3107
Usually, the upgrading of production related software lies under an admin or a person with proper ACLs who defiantly reads the documentation before upgrading. If there is a section in `Upgrade Docs` which indicates `Breaking changes in 0.8.x`, then it is easy to just point the person to a script that can be even downloaded remotely with instructions of how it works. (maybe a place on git called migration):
1. Copy `Notebook` and `conf` directories to `0.8.0`,
2. `curl` the script and run it pointing to new `Notebook` directory,
3. Start the new Zeppelin.
PS: I would say let's have a script and a notebook available for those who would prefer either. But not shipped with Zeppelin. I don't want this Note or script do anything automatically. I would like to download them remotely and follow the instructions from `How to upgrade to 0.8.x`.
---
[GitHub] zeppelin issue #3107: [ZEPPELIN-3646] Add note for updating user permissions
Posted by egorklimov <gi...@git.apache.org>.
Github user egorklimov commented on the issue:
https://github.com/apache/zeppelin/pull/3107
I moved note to `docs` and upgraded instructions, so it would be available in Zeppelin only for those who would follow instructions in Upgrade Docs.
@maziyarpanahi, @felixcheung what do you think about it?
---
[GitHub] zeppelin issue #3107: [ZEPPELIN-3646] Add note for updating user permissions
Posted by egorklimov <gi...@git.apache.org>.
Github user egorklimov commented on the issue:
https://github.com/apache/zeppelin/pull/3107
@felixcheung look again please.
---
[GitHub] zeppelin issue #3107: [ZEPPELIN-3646] Add note for updating user permissions
Posted by egorklimov <gi...@git.apache.org>.
Github user egorklimov commented on the issue:
https://github.com/apache/zeppelin/pull/3107
@felixcheung On other hand, risk of showing all notes may be greater, therefore I think that we should add this workaround, because everyone who is upgrading from any version less than 0.8.x will be faced with this problem, maybe instead of adding this note we could just add python script to project, but IMHO note is better.
---
[GitHub] zeppelin issue #3107: [ZEPPELIN-3646] Add note for updating user permissions
Posted by egorklimov <gi...@git.apache.org>.
Github user egorklimov commented on the issue:
https://github.com/apache/zeppelin/pull/3107
@felixcheung could you point out good place for note/script? Let's close this PR :)
@zjffdu WDYT
---
[GitHub] zeppelin issue #3107: [ZEPPELIN-3646] Add note for updating user permissions
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/3107
I think there is significant risk that some users are just running all “sample” notebook to check them out not fully aware that some might be modifying system state.
Agreed to suggestions above.
---