You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "guohao-rosicky (via GitHub)" <gi...@apache.org> on 2023/08/04 02:31:44 UTC
[GitHub] [ozone] guohao-rosicky opened a new pull request, #5148: HDDS-9120. EC: Add a separate ec rpc timeout in ECXceiverClientGrpc
guohao-rosicky opened a new pull request, #5148:
URL: https://github.com/apache/ozone/pull/5148
## What changes were proposed in this pull request?
Add a separate ec rpc timeout in ECXceiverClientGrpc
Currently the ec rpc timeout is shared with grpc, this pr will add a separate timeout just for ec rpc.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9120. EC: Add a separate ec rpc timeout in ECXceiverClientGrpc [ozone]
Posted by "guohao-rosicky (via GitHub)" <gi...@apache.org>.
guohao-rosicky commented on PR #5148:
URL: https://github.com/apache/ozone/pull/5148#issuecomment-1780666321
> Thanks @guohao-rosicky for the patch. Can we set the default value to match the current timeout (30s)? This would improve flexibility via the new configuration while avoiding unexpected changes upon upgrade.
Thanks @adoroszlai , this a good idea, let me change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] Xushaohong commented on pull request #5148: HDDS-9120. EC: Add a separate ec rpc timeout in ECXceiverClientGrpc
Posted by "Xushaohong (via GitHub)" <gi...@apache.org>.
Xushaohong commented on PR #5148:
URL: https://github.com/apache/ozone/pull/5148#issuecomment-1669409014
Thx @guohao-rosicky for this work.
I wonder why this EC-specific RPC time-out config is proposed. Additionally, why the config in EC is only 10s rather than the default 30s?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] guohao-rosicky commented on pull request #5148: HDDS-9120. EC: Add a separate ec rpc timeout in ECXceiverClientGrpc
Posted by "guohao-rosicky (via GitHub)" <gi...@apache.org>.
guohao-rosicky commented on PR #5148:
URL: https://github.com/apache/ozone/pull/5148#issuecomment-1670610934
@Xushaohong for the review.
1. Because the current timeout is used for both OBJECT reads and EC writes, it is more flexible to set it separately;
2. 10s ec write timeout, because generally we set the ec write chunk size is 512k~1024k, compared to the default chunk of multi-copy 4MB is much smaller.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9120. Add separate timeout config for ECXceiverClientGrpc [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #5148:
URL: https://github.com/apache/ozone/pull/5148
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9120. EC: Add a separate ec rpc timeout in ECXceiverClientGrpc [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #5148:
URL: https://github.com/apache/ozone/pull/5148#issuecomment-1780899520
@siddhantsangwan @sodonnel @umamaheswararao would you like to take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9120. EC: Add a separate ec rpc timeout in ECXceiverClientGrpc [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #5148:
URL: https://github.com/apache/ozone/pull/5148#issuecomment-1779786395
Thanks @guohao-rosicky for the patch. Can we set the default value to match the current timeout (30s)? This would improve flexibility via the new configuration while avoiding unexpected changes upon upgrade.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] guohao-rosicky commented on pull request #5148: HDDS-9120. EC: Add a separate ec rpc timeout in ECXceiverClientGrpc
Posted by "guohao-rosicky (via GitHub)" <gi...@apache.org>.
guohao-rosicky commented on PR #5148:
URL: https://github.com/apache/ozone/pull/5148#issuecomment-1665163568
all ci is passed, see: https://github.com/guohao-rosicky/ozone/actions/runs/5757771231
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org