You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/10/23 00:53:06 UTC
[GitHub] [airflow] potiuk opened a new pull request, #27212: Enable full static checks also when only dev file change
potiuk opened a new pull request, #27212:
URL: https://github.com/apache/airflow/pull/27212
When only dev/ files change we should run all the static tests becuase our flake/mypy checks are also run for the dev files.
We have more scripts than "breeze" in dev and since those change rarely they should be all added to "environment" checks that will trigger full tests.
See #26605 for an example of such PR that did not trigger the full set of tests.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pierrejeambrun merged pull request #27212: Enable full static checks also when only dev file change
Posted by GitBox <gi...@apache.org>.
pierrejeambrun merged PR #27212:
URL: https://github.com/apache/airflow/pull/27212
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #27212: Enable full static checks also when only dev file change
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #27212:
URL: https://github.com/apache/airflow/pull/27212#issuecomment-1287998381
I updated it slightly BTW (better optimised) - only trigger full checks when .py files change in "dev". This way we can save a quite a few build-hours when only updating dev docs for example.
And for the future in case I am not around @pierrejeambrun @ashb @jedcunningham @dstandish @ephraimbuddy - it is super easy to test selective checks locally without invoking CI (commit-ref can be any commi-ish reference):
```
breeze ci selective-check --commit-ref 7d014b0da5c883eac04148289d236b0f56b2a7be
```
This is what it shows when I run it on the change that caused the problem:
You can see:
* "Running everything because env files changed message"
* basic-checks-only = false
(Same output is printed in CI when PR runs)
<img width="1030" alt="Screenshot 2022-10-23 at 06 00 36" src="https://user-images.githubusercontent.com/595491/197373088-1c716550-33ac-449f-8bee-f6c686eb7b54.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #27212: Enable full static checks also when only dev file change
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #27212:
URL: https://github.com/apache/airflow/pull/27212#issuecomment-1287998973
Also I just updated https://github.com/apache/airflow/blob/main/dev/breeze/SELECTIVE_CHECKS.md and all the outputs produced by the selective checks are described in a table explaining what they are used for.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org