You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "efegokdemir (via GitHub)" <gi...@apache.org> on 2026/09/25 05:41:37 UTC
[PR] Support CSS classes in the snippet macro [maven-doxia]
efegokdemir opened a new pull request, #1108:
URL: https://github.com/apache/maven-doxia/pull/1108
## Summary
- Add an optional `class` parameter to the `snippet` macro.
- Forward the value to the verbatim sink event while preserving source decoration.
- Add regression coverage for the generated attributes.
Fixes #1067
## Testing
- `mvn -pl doxia-core -am -Dspotless.skip=true -Dtest=SnippetMacroTest -Dsurefire.failIfNoSpecifiedTests=false test` — passed (3 tests).
- `git diff --check` — passed.
Spotless was skipped for the focused local run because the repository formatter currently fails on the installed JDK 21; the affected tests and compiler checks passed.
AI assistance was used during implementation; the submitted changes were reviewed and validated against the issue and repository tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support CSS classes in the snippet macro [maven-doxia]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz commented on PR #1108:
URL: https://github.com/apache/maven-doxia/pull/1108#issuecomment-5837989082
how it relates to #1106 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support CSS classes in the snippet macro [maven-doxia]
Posted by "efegokdemir (via GitHub)" <gi...@apache.org>.
efegokdemir commented on PR #1108:
URL: https://github.com/apache/maven-doxia/pull/1108#issuecomment-5844498146
You are right — #1108 overlaps with #1106 and both address #1067. #1106 was opened first and uses the existing `SinkEventAttributeSet.SOURCE` attribute while preserving the same regression coverage, so I will treat #1106 as the canonical PR and will not continue parallel changes in #1108.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support CSS classes in the snippet macro [maven-doxia]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz closed pull request #1108: Support CSS classes in the snippet macro
URL: https://github.com/apache/maven-doxia/pull/1108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org