You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2017/09/03 08:43:02 UTC
Re: Review Request 61213: Added 'mesos task list' command to CLI.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61213/
-----------------------------------------------------------
(Updated Sept. 3, 2017, 8:43 a.m.)
Review request for mesos and Kevin Klues.
Changes
-------
Added testing done for High-Availability Mode.
Bugs: MESOS-7840
https://issues.apache.org/jira/browse/MESOS-7840
Repository: mesos
Description (updated)
-------
This command displays the active tasks in a cluster
by reaching the tasks endpoint of a master. It also
works when Mesos uses runs in High-Availability Mode.
Diffs (updated)
-----
src/python/cli_new/bin/settings.py d42df04b0ff42bb6f466842e59223cd90a74d5c0
src/python/cli_new/lib/cli/plugins/task/__init__.py PRE-CREATION
src/python/cli_new/lib/cli/plugins/task/main.py PRE-CREATION
src/python/cli_new/lib/cli/tests/__init__.py 0daf28869e107263c51653ace39e3b1826871048
src/python/cli_new/lib/cli/tests/task.py PRE-CREATION
src/python/cli_new/tests/main.py 3e4d2e449a6485206700b4a490d325a393d31f90
Diff: https://reviews.apache.org/r/61213/diff/2/
Changes: https://reviews.apache.org/r/61213/diff/1-2/
Testing (updated)
-------
To test with one master:
```
$ ./bootstrap
$ source activate
$ mesos-cli-tests
```
To test the command in High-Availability Mode I have:
1. Started ZooKeeper.
2. Started two masters using the flags `--zk` and `--quorum`.
3. Started one agent.
4. Launched one task using `./mesos-execute --master='zk://127.0.0.1:2181/mesos' --name='test' --command='sleep 3600'`.
5. Checked that the output of 'mesos task list' was correct.
I also checked that the Python linter was still working.
Thanks,
Armand Grillet
Re: Review Request 61213: Added 'mesos task list' command to CLI.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61213/#review186264
-----------------------------------------------------------
src/python/cli_new/lib/cli/plugins/task/main.py
Lines 57 (patched)
<https://reviews.apache.org/r/61213/#comment262744>
Save the master address into a temporary variable in its own try block.
- Kevin Klues
On Sept. 4, 2017, 2:49 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61213/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2017, 2:49 p.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-7840
> https://issues.apache.org/jira/browse/MESOS-7840
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This command displays the active tasks in a cluster
> by reaching the tasks endpoint of a master.
>
>
> Diffs
> -----
>
> src/python/cli_new/bin/settings.py d42df04b0ff42bb6f466842e59223cd90a74d5c0
> src/python/cli_new/lib/cli/plugins/task/__init__.py PRE-CREATION
> src/python/cli_new/lib/cli/plugins/task/main.py PRE-CREATION
> src/python/cli_new/lib/cli/tests/__init__.py 0daf28869e107263c51653ace39e3b1826871048
> src/python/cli_new/lib/cli/tests/task.py PRE-CREATION
> src/python/cli_new/tests/main.py 3e4d2e449a6485206700b4a490d325a393d31f90
>
>
> Diff: https://reviews.apache.org/r/61213/diff/4/
>
>
> Testing
> -------
>
> To test with one master:
> ```
> $ ./bootstrap
> $ source activate
> $ mesos-cli-tests
> ```
>
> I also checked that the Python linter was still working.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 61213: Added 'mesos task list' command to CLI.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61213/#review184552
-----------------------------------------------------------
FAIL: 'Mesos testes failed to run'
Reviews applied: [61212, 61213]
Logs available here: 'http://mesos-logs.westus.cloudapp.azure.com/mesos-build/review/61211/logs'
- Mesos Reviewbot Windows
On Sept. 4, 2017, 2:49 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61213/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2017, 2:49 p.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-7840
> https://issues.apache.org/jira/browse/MESOS-7840
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This command displays the active tasks in a cluster
> by reaching the tasks endpoint of a master.
>
>
> Diffs
> -----
>
> src/python/cli_new/bin/settings.py d42df04b0ff42bb6f466842e59223cd90a74d5c0
> src/python/cli_new/lib/cli/plugins/task/__init__.py PRE-CREATION
> src/python/cli_new/lib/cli/plugins/task/main.py PRE-CREATION
> src/python/cli_new/lib/cli/tests/__init__.py 0daf28869e107263c51653ace39e3b1826871048
> src/python/cli_new/lib/cli/tests/task.py PRE-CREATION
> src/python/cli_new/tests/main.py 3e4d2e449a6485206700b4a490d325a393d31f90
>
>
> Diff: https://reviews.apache.org/r/61213/diff/3/
>
>
> Testing
> -------
>
> To test with one master:
> ```
> $ ./bootstrap
> $ source activate
> $ mesos-cli-tests
> ```
>
> To test the command in High-Availability Mode I have:
> 1. Started ZooKeeper.
> 2. Started two masters using the flags `--zk` and `--quorum`.
> 3. Started one agent.
> 4. Launched one task using `./mesos-execute --master='zk://127.0.0.1:2181/mesos' --name='test' --command='sleep 3600'`.
> 5. Checked that the output of 'mesos task list' was correct.
>
> I also checked that the Python linter was still working.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 61213: Added 'mesos task list' command to CLI.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61213/#review186279
-----------------------------------------------------------
PASS: Mesos patch 61213 was successfully built and tested.
Reviews applied: `['61212', '61213']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/61213
- Mesos Reviewbot Windows
On Sept. 26, 2017, 2:57 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61213/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2017, 2:57 p.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-7840
> https://issues.apache.org/jira/browse/MESOS-7840
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This command displays the active tasks in a cluster
> by reaching the tasks endpoint of a master.
>
>
> Diffs
> -----
>
> src/python/cli_new/bin/settings.py d42df04b0ff42bb6f466842e59223cd90a74d5c0
> src/python/cli_new/lib/cli/plugins/task/__init__.py PRE-CREATION
> src/python/cli_new/lib/cli/plugins/task/main.py PRE-CREATION
> src/python/cli_new/lib/cli/tests/__init__.py 0daf28869e107263c51653ace39e3b1826871048
> src/python/cli_new/lib/cli/tests/task.py PRE-CREATION
> src/python/cli_new/tests/main.py 3e4d2e449a6485206700b4a490d325a393d31f90
>
>
> Diff: https://reviews.apache.org/r/61213/diff/5/
>
>
> Testing
> -------
>
> To test with one master:
> ```
> $ ./bootstrap
> $ source activate
> $ mesos-cli-tests
> ```
>
> I also checked that the Python linter was still working.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 61213: Added 'mesos task list' command to CLI.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61213/#review186265
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Klues
On Sept. 26, 2017, 2:57 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61213/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2017, 2:57 p.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-7840
> https://issues.apache.org/jira/browse/MESOS-7840
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This command displays the active tasks in a cluster
> by reaching the tasks endpoint of a master.
>
>
> Diffs
> -----
>
> src/python/cli_new/bin/settings.py d42df04b0ff42bb6f466842e59223cd90a74d5c0
> src/python/cli_new/lib/cli/plugins/task/__init__.py PRE-CREATION
> src/python/cli_new/lib/cli/plugins/task/main.py PRE-CREATION
> src/python/cli_new/lib/cli/tests/__init__.py 0daf28869e107263c51653ace39e3b1826871048
> src/python/cli_new/lib/cli/tests/task.py PRE-CREATION
> src/python/cli_new/tests/main.py 3e4d2e449a6485206700b4a490d325a393d31f90
>
>
> Diff: https://reviews.apache.org/r/61213/diff/5/
>
>
> Testing
> -------
>
> To test with one master:
> ```
> $ ./bootstrap
> $ source activate
> $ mesos-cli-tests
> ```
>
> I also checked that the Python linter was still working.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 61213: Added 'mesos task list' command to CLI.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61213/
-----------------------------------------------------------
(Updated Sept. 26, 2017, 2:57 p.m.)
Review request for mesos and Kevin Klues.
Changes
-------
Resolved issue.
Bugs: MESOS-7840
https://issues.apache.org/jira/browse/MESOS-7840
Repository: mesos
Description
-------
This command displays the active tasks in a cluster
by reaching the tasks endpoint of a master.
Diffs (updated)
-----
src/python/cli_new/bin/settings.py d42df04b0ff42bb6f466842e59223cd90a74d5c0
src/python/cli_new/lib/cli/plugins/task/__init__.py PRE-CREATION
src/python/cli_new/lib/cli/plugins/task/main.py PRE-CREATION
src/python/cli_new/lib/cli/tests/__init__.py 0daf28869e107263c51653ace39e3b1826871048
src/python/cli_new/lib/cli/tests/task.py PRE-CREATION
src/python/cli_new/tests/main.py 3e4d2e449a6485206700b4a490d325a393d31f90
Diff: https://reviews.apache.org/r/61213/diff/5/
Changes: https://reviews.apache.org/r/61213/diff/4-5/
Testing
-------
To test with one master:
```
$ ./bootstrap
$ source activate
$ mesos-cli-tests
```
I also checked that the Python linter was still working.
Thanks,
Armand Grillet
Re: Review Request 61213: Added 'mesos task list' command to CLI.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61213/
-----------------------------------------------------------
(Updated Sept. 4, 2017, 2:49 p.m.)
Review request for mesos and Kevin Klues.
Changes
-------
Updated list method.
Bugs: MESOS-7840
https://issues.apache.org/jira/browse/MESOS-7840
Repository: mesos
Description (updated)
-------
This command displays the active tasks in a cluster
by reaching the tasks endpoint of a master.
Diffs (updated)
-----
src/python/cli_new/bin/settings.py d42df04b0ff42bb6f466842e59223cd90a74d5c0
src/python/cli_new/lib/cli/plugins/task/__init__.py PRE-CREATION
src/python/cli_new/lib/cli/plugins/task/main.py PRE-CREATION
src/python/cli_new/lib/cli/tests/__init__.py 0daf28869e107263c51653ace39e3b1826871048
src/python/cli_new/lib/cli/tests/task.py PRE-CREATION
src/python/cli_new/tests/main.py 3e4d2e449a6485206700b4a490d325a393d31f90
Diff: https://reviews.apache.org/r/61213/diff/3/
Changes: https://reviews.apache.org/r/61213/diff/2-3/
Testing
-------
To test with one master:
```
$ ./bootstrap
$ source activate
$ mesos-cli-tests
```
To test the command in High-Availability Mode I have:
1. Started ZooKeeper.
2. Started two masters using the flags `--zk` and `--quorum`.
3. Started one agent.
4. Launched one task using `./mesos-execute --master='zk://127.0.0.1:2181/mesos' --name='test' --command='sleep 3600'`.
5. Checked that the output of 'mesos task list' was correct.
I also checked that the Python linter was still working.
Thanks,
Armand Grillet
Re: Review Request 61213: Added 'mesos task list' command to CLI.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61213/#review184482
-----------------------------------------------------------
Patch looks great!
Reviews applied: [60088, 61212, 61213]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Sept. 3, 2017, 10:43 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61213/
> -----------------------------------------------------------
>
> (Updated Sept. 3, 2017, 10:43 a.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-7840
> https://issues.apache.org/jira/browse/MESOS-7840
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This command displays the active tasks in a cluster
> by reaching the tasks endpoint of a master. It also
> works when Mesos uses runs in High-Availability Mode.
>
>
> Diffs
> -----
>
> src/python/cli_new/bin/settings.py d42df04b0ff42bb6f466842e59223cd90a74d5c0
> src/python/cli_new/lib/cli/plugins/task/__init__.py PRE-CREATION
> src/python/cli_new/lib/cli/plugins/task/main.py PRE-CREATION
> src/python/cli_new/lib/cli/tests/__init__.py 0daf28869e107263c51653ace39e3b1826871048
> src/python/cli_new/lib/cli/tests/task.py PRE-CREATION
> src/python/cli_new/tests/main.py 3e4d2e449a6485206700b4a490d325a393d31f90
>
>
> Diff: https://reviews.apache.org/r/61213/diff/2/
>
>
> Testing
> -------
>
> To test with one master:
> ```
> $ ./bootstrap
> $ source activate
> $ mesos-cli-tests
> ```
>
> To test the command in High-Availability Mode I have:
> 1. Started ZooKeeper.
> 2. Started two masters using the flags `--zk` and `--quorum`.
> 3. Started one agent.
> 4. Launched one task using `./mesos-execute --master='zk://127.0.0.1:2181/mesos' --name='test' --command='sleep 3600'`.
> 5. Checked that the output of 'mesos task list' was correct.
>
> I also checked that the Python linter was still working.
>
>
> Thanks,
>
> Armand Grillet
>
>