You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fory.apache.org by "chaokunyang (via GitHub)" <gi...@apache.org> on 2026/02/28 11:25:43 UTC
[PR] docs: add ai contributing policy [fory]
chaokunyang opened a new pull request, #3437:
URL: https://github.com/apache/fory/pull/3437
## Why?
add ai contributing policy to keep project quality, legal safety, and maintainability standards
## What does this PR do?
<!-- Describe the details of this PR. -->
## Related issues
<!--
Is there any related issue? If this PR closes them you say say fix/closes:
- #xxxx0
- #xxxx1
- Fixes #xxxx2
-->
## Does this PR introduce any user-facing change?
<!--
If any user-facing interface changes, please [open an issue](https://github.com/apache/fory/issues/new/choose) describing the need to do so and update the document if necessary.
Delete section if not applicable.
-->
- [ ] Does this PR introduce any public API change?
- [ ] Does this PR introduce any binary protocol compatibility change?
## Benchmark
<!--
When the PR has an impact on performance (if you don't know whether the PR will have an impact on performance, you can submit the PR first, and if it will have impact on performance, the code reviewer will explain it), be sure to attach a benchmark data here.
Delete section if not applicable.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org
Re: [PR] docs: add ai contributing policy [fory]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang merged PR #3437:
URL: https://github.com/apache/fory/pull/3437
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org
Re: [PR] docs: add ai contributing policy [fory]
Posted by "pandalee99 (via GitHub)" <gi...@apache.org>.
pandalee99 commented on code in PR #3437:
URL: https://github.com/apache/fory/pull/3437#discussion_r2867450231
##########
AI_CONTRIBUTION_POLICY.md:
##########
@@ -0,0 +1,127 @@
+# AI Contribution Policy
+
+Apache Fory is a performance-critical foundational serialization framework with cross-language compatibility requirements.
+AI tools are welcome as assistants, but project quality, legal safety, and maintainability standards are unchanged.
+
+The key words MUST, MUST NOT, REQUIRED, SHOULD, and MAY are interpreted as described in RFC 2119.
+
+## 1. Core Principle
+
+- AI tools MAY assist contribution work.
+- AI tools MUST NOT replace contributor accountability.
+- The human submitter is responsible for correctness, safety, performance, and maintainability of all submitted changes.
+- AI-assisted code MUST be reviewed carefully by the contributor line by line before submission.
+- Contributors MUST be able to explain and defend design and implementation details during review.
+
+## 2. Disclosure (Privacy-Safe)
+
+For substantial AI assistance, PR descriptions MUST include a short `AI Usage Disclosure` section.
Review Comment:
How many lines of code, how large a change, or to what extent of AI involvement counts as substantial? It could be as simple as adding a single function, or just revising a short comment. Could we further define and clarify this specification?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org
Re: [PR] docs: add ai contributing policy [fory]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang commented on code in PR #3437:
URL: https://github.com/apache/fory/pull/3437#discussion_r2867498669
##########
AI_CONTRIBUTION_POLICY.md:
##########
@@ -0,0 +1,127 @@
+# AI Contribution Policy
+
+Apache Fory is a performance-critical foundational serialization framework with cross-language compatibility requirements.
+AI tools are welcome as assistants, but project quality, legal safety, and maintainability standards are unchanged.
+
+The key words MUST, MUST NOT, REQUIRED, SHOULD, and MAY are interpreted as described in RFC 2119.
+
+## 1. Core Principle
+
+- AI tools MAY assist contribution work.
+- AI tools MUST NOT replace contributor accountability.
+- The human submitter is responsible for correctness, safety, performance, and maintainability of all submitted changes.
+- AI-assisted code MUST be reviewed carefully by the contributor line by line before submission.
+- Contributors MUST be able to explain and defend design and implementation details during review.
+
+## 2. Disclosure (Privacy-Safe)
+
+For substantial AI assistance, PR descriptions MUST include a short `AI Usage Disclosure` section.
Review Comment:
This is indeed ambiguous. I added some claryfication:
Definition of substantial AI assistance:
- Substantial means AI materially influenced technical content, not only writing style.
- Contributors MUST mark AI assistance as substantial (`yes`) if any of the following apply:
- AI generated or rewrote non-trivial code/test logic (even for a small change or a single function).
- AI-generated or AI-refactored content is about 20 or more added/changed lines in aggregate.
- AI materially influenced API, protocol, type mapping, performance, memory, or architecture decisions.
- AI produced substantive technical text used in PR rationale (beyond grammar/translation cleanup).
- Contributors MAY mark substantial AI assistance as `no` for minor or narrow assistance only, such as spelling/grammar fixes, formatting, trivial comment wording edits, or other non-technical edits with no behavior impact.
Required disclosure fields:
- Whether substantial AI assistance was used (`yes` or `no`)
- Scope of assistance (for example: design drafting, code drafting, refactor suggestions, tests, docs)
- Affected files or subsystems (high-level)
- Human verification performed (checks run locally or in CI, and results reviewed by the contributor)
- Provenance and license confirmation (see Section 6)
Standard disclosure template (recommended):
```text
AI Usage Disclosure
- substantial_ai_assistance: yes
- scope: <design drafting | code drafting | refactor suggestions | tests | docs | other>
- affected_files_or_subsystems: <high-level paths/modules>
- human_verification: <checks run locally or in CI + pass/fail summary + contributor reviewed results>
- performance_verification: <N/A or benchmark/regression evidence summary>
- provenance_license_confirmation: <Apache-2.0-compatible provenance confirmed; no incompatible third-party code introduced>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org
Re: [PR] docs: add ai contributing policy [fory]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang commented on code in PR #3437:
URL: https://github.com/apache/fory/pull/3437#discussion_r2867498669
##########
AI_CONTRIBUTION_POLICY.md:
##########
@@ -0,0 +1,127 @@
+# AI Contribution Policy
+
+Apache Fory is a performance-critical foundational serialization framework with cross-language compatibility requirements.
+AI tools are welcome as assistants, but project quality, legal safety, and maintainability standards are unchanged.
+
+The key words MUST, MUST NOT, REQUIRED, SHOULD, and MAY are interpreted as described in RFC 2119.
+
+## 1. Core Principle
+
+- AI tools MAY assist contribution work.
+- AI tools MUST NOT replace contributor accountability.
+- The human submitter is responsible for correctness, safety, performance, and maintainability of all submitted changes.
+- AI-assisted code MUST be reviewed carefully by the contributor line by line before submission.
+- Contributors MUST be able to explain and defend design and implementation details during review.
+
+## 2. Disclosure (Privacy-Safe)
+
+For substantial AI assistance, PR descriptions MUST include a short `AI Usage Disclosure` section.
Review Comment:
This is indeed ambiguous. I added some clarification:
Definition of substantial AI assistance:
- Substantial means AI materially influenced technical content, not only writing style.
- Contributors MUST mark AI assistance as substantial (`yes`) if any of the following apply:
- AI generated or rewrote non-trivial code/test logic (even for a small change or a single function).
- AI-generated or AI-refactored content is about 20 or more added/changed lines in aggregate.
- AI materially influenced API, protocol, type mapping, performance, memory, or architecture decisions.
- AI produced substantive technical text used in PR rationale (beyond grammar/translation cleanup).
- Contributors MAY mark substantial AI assistance as `no` for minor or narrow assistance only, such as spelling/grammar fixes, formatting, trivial comment wording edits, or other non-technical edits with no behavior impact.
Required disclosure fields:
- Whether substantial AI assistance was used (`yes` or `no`)
- Scope of assistance (for example: design drafting, code drafting, refactor suggestions, tests, docs)
- Affected files or subsystems (high-level)
- Human verification performed (checks run locally or in CI, and results reviewed by the contributor)
- Provenance and license confirmation (see Section 6)
Standard disclosure template (recommended):
```text
AI Usage Disclosure
- substantial_ai_assistance: yes
- scope: <design drafting | code drafting | refactor suggestions | tests | docs | other>
- affected_files_or_subsystems: <high-level paths/modules>
- human_verification: <checks run locally or in CI + pass/fail summary + contributor reviewed results>
- performance_verification: <N/A or benchmark/regression evidence summary>
- provenance_license_confirmation: <Apache-2.0-compatible provenance confirmed; no incompatible third-party code introduced>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org
Re: [PR] docs: add ai contributing policy [fory]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #3437:
URL: https://github.com/apache/fory/pull/3437#discussion_r2867443101
##########
AI_CONTRIBUTION_POLICY.md:
##########
@@ -0,0 +1,127 @@
+# AI Contribution Policy
+
+Apache Fory is a performance-critical foundational serialization framework with cross-language compatibility requirements.
+AI tools are welcome as assistants, but project quality, legal safety, and maintainability standards are unchanged.
+
+The key words MUST, MUST NOT, REQUIRED, SHOULD, and MAY are interpreted as described in RFC 2119.
+
+## 1. Core Principle
+
+- AI tools MAY assist contribution work.
+- AI tools MUST NOT replace contributor accountability.
+- The human submitter is responsible for correctness, safety, performance, and maintainability of all submitted changes.
+- AI-assisted code MUST be reviewed carefully by the contributor line by line before submission.
+- Contributors MUST be able to explain and defend design and implementation details during review.
+
+## 2. Disclosure (Privacy-Safe)
+
+For substantial AI assistance, PR descriptions MUST include a short `AI Usage Disclosure` section.
+
+Required disclosure fields:
+
+- Whether substantial AI assistance was used (`yes` or `no`)
+- Scope of assistance (for example: design drafting, code drafting, refactor suggestions, tests, docs)
+- Affected files or subsystems (high-level)
+- Human verification performed (commands/tests/benchmarks executed)
+- Provenance and license confirmation (see Section 6)
Review Comment:
Can you mention license confirmation as a core principle?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org
Re: [PR] docs: add ai contributing policy [fory]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang commented on code in PR #3437:
URL: https://github.com/apache/fory/pull/3437#discussion_r2867495382
##########
AI_CONTRIBUTION_POLICY.md:
##########
@@ -0,0 +1,127 @@
+# AI Contribution Policy
+
+Apache Fory is a performance-critical foundational serialization framework with cross-language compatibility requirements.
+AI tools are welcome as assistants, but project quality, legal safety, and maintainability standards are unchanged.
+
+The key words MUST, MUST NOT, REQUIRED, SHOULD, and MAY are interpreted as described in RFC 2119.
+
+## 1. Core Principle
+
+- AI tools MAY assist contribution work.
+- AI tools MUST NOT replace contributor accountability.
+- The human submitter is responsible for correctness, safety, performance, and maintainability of all submitted changes.
+- AI-assisted code MUST be reviewed carefully by the contributor line by line before submission.
+- Contributors MUST be able to explain and defend design and implementation details during review.
+
+## 2. Disclosure (Privacy-Safe)
+
+For substantial AI assistance, PR descriptions MUST include a short `AI Usage Disclosure` section.
+
+Required disclosure fields:
+
+- Whether substantial AI assistance was used (`yes` or `no`)
+- Scope of assistance (for example: design drafting, code drafting, refactor suggestions, tests, docs)
+- Affected files or subsystems (high-level)
+- Human verification performed (commands/tests/benchmarks executed)
+- Provenance and license confirmation (see Section 6)
Review Comment:
added a point:
- License/provenance confirmation: contributors MUST confirm submitted material is legally compatible and traceable, and MUST comply with [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org