You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2012/08/08 20:04:20 UTC

[jira] [Commented] (THRIFT-1671) Cocoa code generator does not put keywords into generated method calls

    [ https://issues.apache.org/jira/browse/THRIFT-1671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13431256#comment-13431256 ] 

Hudson commented on THRIFT-1671:
--------------------------------

Integrated in Thrift #514 (See [https://builds.apache.org/job/Thrift/514/])
    Thrift-1671:Cocoa code generator does not put keywords into generated method calls
Client: cocoa
Patch: Jan Brauer

Adds keywords into generated method calls. (Revision 1370855)

     Result = FAILURE
                
> Cocoa code generator does not put keywords into generated method calls
> ----------------------------------------------------------------------
>
>                 Key: THRIFT-1671
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1671
>             Project: Thrift
>          Issue Type: Bug
>          Components: Cocoa - Compiler
>    Affects Versions: 0.9
>            Reporter: Jan Brauer
>            Assignee: Jan Brauer
>             Fix For: 0.9
>
>         Attachments: argument_for_method_calls.patch
>
>
> In THRIFT-541 keywords where introduced to method declarations. But the actual call to the method omits them. That leads to errors as:
> {noformat}
> pages.m:2558:3: warning: instance method '-send_deletePage::' not found (return type defaults to 'id')
>   [self send_deletePage: websiteId : pageId];
>   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> pages.m:2764:23: warning: instance method '-getPage::' not found (return type defaults to 'id')
>   [result setSuccess: [mService getPage: [args websiteId]: [args pageId]]];
>                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> pages.m:2781:3: warning: instance method '-deletePage::' not found (return type defaults to 'id')
>   [mService deletePage: [args websiteId]: [args pageId]];
>   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> {noformat}
> The attached patch fixes that.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira