You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mc...@gmail.com> on 2015/04/23 18:38:56 UTC
Re: Review Request 32149: Enabled 'Resources::apply' to handle
reservation operations.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32149/
-----------------------------------------------------------
(Updated April 23, 2015, 4:38 p.m.)
Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu.
Changes
-------
Added a test for `unreserve`.
Bugs: MESOS-2477
https://issues.apache.org/jira/browse/MESOS-2477
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/common/resources.cpp 2c99b6884d7296099e19e2e3182cbe11b5e1e059
src/tests/resources_tests.cpp 7e0ad98c3366f647f190363a0e6b576dbfc7d415
Diff: https://reviews.apache.org/r/32149/diff/
Testing
-------
make check
Thanks,
Michael Park
Re: Review Request 32149: Enabled 'Resources::apply' to handle
reservation operations.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32149/#review82348
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On May 1, 2015, 10:50 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32149/
> -----------------------------------------------------------
>
> (Updated May 1, 2015, 10:50 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu.
>
>
> Bugs: MESOS-2477
> https://issues.apache.org/jira/browse/MESOS-2477
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/common/resources.cpp 2c99b6884d7296099e19e2e3182cbe11b5e1e059
> src/tests/resources_tests.cpp 7e0ad98c3366f647f190363a0e6b576dbfc7d415
>
> Diff: https://reviews.apache.org/r/32149/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 32149: Enabled 'Resources::apply' to handle
reservation operations.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32149/
-----------------------------------------------------------
(Updated May 1, 2015, 10:50 p.m.)
Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu.
Changes
-------
Addressed Jie's comment.
Bugs: MESOS-2477
https://issues.apache.org/jira/browse/MESOS-2477
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/common/resources.cpp 2c99b6884d7296099e19e2e3182cbe11b5e1e059
src/tests/resources_tests.cpp 7e0ad98c3366f647f190363a0e6b576dbfc7d415
Diff: https://reviews.apache.org/r/32149/diff/
Testing
-------
make check
Thanks,
Michael Park
Re: Review Request 32149: Enabled 'Resources::apply' to handle
reservation operations.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32149/
-----------------------------------------------------------
(Updated April 27, 2015, 5:48 p.m.)
Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu.
Changes
-------
`s/snake_case/camelCase/`
Bugs: MESOS-2477
https://issues.apache.org/jira/browse/MESOS-2477
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/common/resources.cpp 2c99b6884d7296099e19e2e3182cbe11b5e1e059
src/tests/resources_tests.cpp 7e0ad98c3366f647f190363a0e6b576dbfc7d415
Diff: https://reviews.apache.org/r/32149/diff/
Testing
-------
make check
Thanks,
Michael Park
Re: Review Request 32149: Enabled 'Resources::apply' to handle
reservation operations.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32149/#review81349
-----------------------------------------------------------
Ship it!
Ship It!
- Timothy Chen
On April 23, 2015, 4:38 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32149/
> -----------------------------------------------------------
>
> (Updated April 23, 2015, 4:38 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu.
>
>
> Bugs: MESOS-2477
> https://issues.apache.org/jira/browse/MESOS-2477
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/common/resources.cpp 2c99b6884d7296099e19e2e3182cbe11b5e1e059
> src/tests/resources_tests.cpp 7e0ad98c3366f647f190363a0e6b576dbfc7d415
>
> Diff: https://reviews.apache.org/r/32149/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 32149: Enabled 'Resources::apply' to handle
reservation operations.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32149/#review81364
-----------------------------------------------------------
src/tests/resources_tests.cpp
<https://reviews.apache.org/r/32149/#comment131708>
We do not use `snake_case`. Please use unreservedCpus and unreservedMem.
src/tests/resources_tests.cpp
<https://reviews.apache.org/r/32149/#comment131709>
Ditto.
- Jie Yu
On April 23, 2015, 4:38 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32149/
> -----------------------------------------------------------
>
> (Updated April 23, 2015, 4:38 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu.
>
>
> Bugs: MESOS-2477
> https://issues.apache.org/jira/browse/MESOS-2477
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/common/resources.cpp 2c99b6884d7296099e19e2e3182cbe11b5e1e059
> src/tests/resources_tests.cpp 7e0ad98c3366f647f190363a0e6b576dbfc7d415
>
> Diff: https://reviews.apache.org/r/32149/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Michael Park
>
>