You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-issues@jackrabbit.apache.org by "angela (JIRA)" <ji...@apache.org> on 2016/10/27 09:15:59 UTC

[jira] [Assigned] (OAK-4696) Improve logging for SyncHandler

     [ https://issues.apache.org/jira/browse/OAK-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

angela reassigned OAK-4696:
---------------------------

    Assignee: angela

> Improve logging for SyncHandler
> -------------------------------
>
>                 Key: OAK-4696
>                 URL: https://issues.apache.org/jira/browse/OAK-4696
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: auth-external
>    Affects Versions: 1.5.8
>            Reporter: Konrad Windszus
>            Assignee: angela
>
> In the {{ExternalLoginModule.syncUser}} the {{context.sync(..)}} is being called without evaluating the return value at all (https://github.com/apache/jackrabbit-oak/blob/trunk/oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/ExternalLoginModule.java#L354). The return value should be logged to find out, which sync took place.
> Also I am wondering if it would make sense to do the {{root.commit()}} only conditionally in case the return value is not {{SyncResult.NOP}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)