You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@sentry.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2017/05/01 23:31:04 UTC

[jira] [Commented] (SENTRY-1744) Simplify creation of DelegateSentryStore

    [ https://issues.apache.org/jira/browse/SENTRY-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991783#comment-15991783 ] 

Hadoop QA commented on SENTRY-1744:
-----------------------------------

Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12865827/SENTRY-1744.001.patch against master.

{color:green}Overall:{color} +1 all checks pass

{color:green}SUCCESS:{color} all tests passed

Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/2614/console

This message is automatically generated.

> Simplify creation of DelegateSentryStore
> ----------------------------------------
>
>                 Key: SENTRY-1744
>                 URL: https://issues.apache.org/jira/browse/SENTRY-1744
>             Project: Sentry
>          Issue Type: Improvement
>          Components: Sentry
>    Affects Versions: 1.8.0, sentry-ha-redesign
>            Reporter: Alexander Kolbasov
>            Assignee: Alexander Kolbasov
>         Attachments: SENTRY-1744.001.patch
>
>
> It looks like we have a very "generic" code in SentryGenericPolicyProcessor that creates DelegateSentryStore based on the class name which may be changed in configuration. This is very cute, but sounds quite complicated to me. I don't know the history here, but I would suggest removing this and just creating DelegateSentryStore directly.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)