You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Zakelly (via GitHub)" <gi...@apache.org> on 2024/12/07 09:29:18 UTC

[PR] [FLINK-36859][Runtime] Fix wrong epoch/watermark firing in async state processing [flink]

Zakelly opened a new pull request, #25761:
URL: https://github.com/apache/flink/pull/25761

   ## What is the purpose of the change
   
   Currently, we use `EpochManager` to manage the watermark in async state processing. We found an issue when a watermark reached and no further input reach for a while, the epoch/watermark will be triggered twice. Current PR fix this.
   
   ## Brief change log
   
    - Stricter conditions to ensure no recursive call of triggering.
   
   ## Verifying this change
   
   This change modified test `EpochManagerTest` that can verify this.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-36859][Runtime] Fix wrong epoch/watermark firing in async state processing [flink]

Posted by "Zakelly (via GitHub)" <gi...@apache.org>.
Zakelly commented on PR #25761:
URL: https://github.com/apache/flink/pull/25761#issuecomment-2526722949

   Thanks for the review, merging...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-36859][Runtime] Fix wrong epoch/watermark firing in async state processing [flink]

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #25761:
URL: https://github.com/apache/flink/pull/25761#issuecomment-2525050672

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ee74be819f224709b61be4df5d4ffdc7cda70bd6",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ee74be819f224709b61be4df5d4ffdc7cda70bd6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ee74be819f224709b61be4df5d4ffdc7cda70bd6 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-36859][Runtime] Fix wrong epoch/watermark firing in async state processing [flink]

Posted by "Zakelly (via GitHub)" <gi...@apache.org>.
Zakelly merged PR #25761:
URL: https://github.com/apache/flink/pull/25761


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org