You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/17 09:59:22 UTC

[GitHub] [flink] pnowojski commented on issue #11097: [FLINK-16057][runtime] chain ContinuousFileReaderOperator by default

pnowojski commented on issue #11097: [FLINK-16057][runtime] chain ContinuousFileReaderOperator by default
URL: https://github.com/apache/flink/pull/11097#issuecomment-586910454
 
 
   Yes,
   
   1. for one thing operators that do use `mailbox.yield()`, can not be chained with the legacy sources.
   2. CFRO is always 2nd operator in the job graph, just after the legacy `SourceFunction`, so effectively it has to be always a head of the chain plus I think `SourceFunction` for `CFRO` has always parallelism 1, so all in all enabling chaining in benchmarks is a bit unrealistic setup. 
   3. As far as I can see, before your changes @rkhachatryan, the CFRO was not chained in the benchmarks. So this change is not fixing the performance regression, but only hiding it behind some other unrelated improvement, or am I missing something?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services