You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "wirybeaver (via GitHub)" <gi...@apache.org> on 2023/05/08 03:14:59 UTC

[GitHub] [pinot] wirybeaver opened a new issue, #10740: Delete segments whose min-max falls into the given time range

wirybeaver opened a new issue, #10740:
URL: https://github.com/apache/pinot/issues/10740

   Requirement: Delete segments within the timestamp.
   Scenario: Delete massive number of segments in the PoC phase. The associate Kafka topic has high throughput.
   Solution: Current segment deletion api requires user manually input segment list. We can add another api with the parameters fromTimestamp and endTimestamp. Then reuse the PinotHelixResourceManager' getSegmentsFor to get segment list and pass into the existing deleteSegments api.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] wirybeaver commented on issue #10740: Delete segments whose min-max falls into the given time range

Posted by "wirybeaver (via GitHub)" <gi...@apache.org>.
wirybeaver commented on issue #10740:
URL: https://github.com/apache/pinot/issues/10740#issuecomment-1564684466

   > cc @snleee Can you help guiding @wirybeaver to finish this feature? Make sure it works seamlessly with the future time based segment replacement
   
   Hi Jackie, I already have an draft implementation. I used the existing up-to-date interface of GetSegments(time_range), which should exactly works with the future time based segment replacement


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] wirybeaver commented on issue #10740: Delete segments whose min-max falls into the given time range

Posted by "wirybeaver (via GitHub)" <gi...@apache.org>.
wirybeaver commented on issue #10740:
URL: https://github.com/apache/pinot/issues/10740#issuecomment-1564682127

   > @wirybeaver : what does the "min-max" in the GH description referring to?
   > 
   > Side note: is it ok if we assign this issue to you?
   
   Yeah, I am good for the assignee. I already have a implementation in Draft state. Need to finish the unit test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] wirybeaver closed issue #10740: Delete segments whose min-max falls into the given time range

Posted by "wirybeaver (via GitHub)" <gi...@apache.org>.
wirybeaver closed issue #10740: Delete segments whose min-max falls into the given time range
URL: https://github.com/apache/pinot/issues/10740


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] navina commented on issue #10740: Delete segments whose min-max falls into the given time range

Posted by "navina (via GitHub)" <gi...@apache.org>.
navina commented on issue #10740:
URL: https://github.com/apache/pinot/issues/10740#issuecomment-1560231609

   @wirybeaver : what does the "min-max" in the GH description referring to?
   
   Side note: is it ok if we assign this issue to you? 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] Jackie-Jiang commented on issue #10740: Delete segments whose min-max falls into the given time range

Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on issue #10740:
URL: https://github.com/apache/pinot/issues/10740#issuecomment-1564678707

   cc @snleee Can you help guiding @wirybeaver to finish this feature? Make sure it works seamlessly with the future time based segment replacement


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] wirybeaver commented on issue #10740: Delete segments whose min-max falls into the given time range

Posted by "wirybeaver (via GitHub)" <gi...@apache.org>.
wirybeaver commented on issue #10740:
URL: https://github.com/apache/pinot/issues/10740#issuecomment-1694920595

   the api is merged already


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org