You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Niklas Nielsen <ni...@qni.dk> on 2016/01/19 14:25:19 UTC
Re: Review Request 39845: Added REASON_RESOURCE_OVERSUBSCRIBED to
mesos proto.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39845/#review115153
-----------------------------------------------------------
include/mesos/mesos.proto (line 1121)
<https://reviews.apache.org/r/39845/#comment176043>
To Vinod's point; can we reuse the preempted status?
'Resource oversubscribed' seems a bit counter intuitive as a error message, as that is what you tried to do in the first place :)
- Niklas Nielsen
On Jan. 19, 2016, 2:39 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39845/
> -----------------------------------------------------------
>
> (Updated Jan. 19, 2016, 2:39 a.m.)
>
>
> Review request for mesos, Niklas Nielsen and Vinod Kone.
>
>
> Bugs: MESOS-2647
> https://issues.apache.org/jira/browse/MESOS-2647
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added REASON_RESOURCE_OVERSUBSCRIBED to mesos proto.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 94004343ea615d87d7c7d63a6a81aaaa1cf8002e
> include/mesos/v1/mesos.proto 8131778fe5c5f3a47ae9300a811e3d857a22da6a
>
> Diff: https://reviews.apache.org/r/39845/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 39845: Added REASON_RESOURCE_OVERSUBSCRIBED to
mesos proto.
Posted by Guangya Liu <gy...@gmail.com>.
> On 一月 19, 2016, 1:25 p.m., Niklas Nielsen wrote:
> > include/mesos/mesos.proto, line 1121
> > <https://reviews.apache.org/r/39845/diff/1/?file=1113968#file1113968line1121>
> >
> > To Vinod's point; can we reuse the preempted status?
> >
> > 'Resource oversubscribed' seems a bit counter intuitive as a error message, as that is what you tried to do in the first place :)
Reuse which one? What about adding REASON_RESOURCES_PREEMPTED?
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39845/#review115153
-----------------------------------------------------------
On 一月 19, 2016, 10:39 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39845/
> -----------------------------------------------------------
>
> (Updated 一月 19, 2016, 10:39 a.m.)
>
>
> Review request for mesos, Niklas Nielsen and Vinod Kone.
>
>
> Bugs: MESOS-2647
> https://issues.apache.org/jira/browse/MESOS-2647
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added REASON_RESOURCE_OVERSUBSCRIBED to mesos proto.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 94004343ea615d87d7c7d63a6a81aaaa1cf8002e
> include/mesos/v1/mesos.proto 8131778fe5c5f3a47ae9300a811e3d857a22da6a
>
> Diff: https://reviews.apache.org/r/39845/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>