You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/05/04 12:57:16 UTC
[GitHub] [incubator-nuttx-testing] yamt opened a new pull request #42: Some cibuild.sh improvements
yamt opened a new pull request #42:
URL: https://github.com/apache/incubator-nuttx-testing/pull/42
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] liuguo09 commented on a change in pull request #42: Some cibuild.sh improvements
Posted by GitBox <gi...@apache.org>.
liuguo09 commented on a change in pull request #42:
URL: https://github.com/apache/incubator-nuttx-testing/pull/42#discussion_r420629105
##########
File path: cibuild.sh
##########
@@ -48,6 +48,14 @@ function python-tools {
PYTHONUSERBASE=$prebuilt/pylocal
export PYTHONUSERBASE
add_path $PYTHONUSERBASE/bin
+ case $os in
+ Darwin)
+ PIP=pip3
Review comment:
@btashton Sorry for my misunderstanding. Glad to hear that you could help to change Jenkins config to run the contianer. There used to be several times asking for infra team to install new tools in need. This could make it more easy to maintain.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] yamt commented on a change in pull request #42: Some cibuild.sh improvements
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #42:
URL: https://github.com/apache/incubator-nuttx-testing/pull/42#discussion_r419491601
##########
File path: cibuild.sh
##########
@@ -289,6 +291,8 @@ function install_tools {
$func
done
popd
+
+ echo PATH=$EXTRA_PATH\$PATH > $prebuilt/env.sh
Review comment:
i used it to set up my development env.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] btashton commented on a change in pull request #42: Some cibuild.sh improvements
Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #42:
URL: https://github.com/apache/incubator-nuttx-testing/pull/42#discussion_r420533197
##########
File path: cibuild.sh
##########
@@ -48,6 +48,14 @@ function python-tools {
PYTHONUSERBASE=$prebuilt/pylocal
export PYTHONUSERBASE
add_path $PYTHONUSERBASE/bin
+ case $os in
+ Darwin)
+ PIP=pip3
Review comment:
I wonder if they have python3 installed at all (we should since python 2 is EOL). We could try |python3 -m pip` for pip3.
Do we have any information on what the build machine is built with?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] yamt commented on a change in pull request #42: Some cibuild.sh improvements
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #42:
URL: https://github.com/apache/incubator-nuttx-testing/pull/42#discussion_r419491173
##########
File path: cibuild.sh
##########
@@ -48,6 +48,14 @@ function python-tools {
PYTHONUSERBASE=$prebuilt/pylocal
export PYTHONUSERBASE
add_path $PYTHONUSERBASE/bin
+ case $os in
+ Darwin)
+ PIP=pip3
Review comment:
maybe. i just don't want to break linux.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in pull request #42: Some cibuild.sh improvements
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #42:
URL: https://github.com/apache/incubator-nuttx-testing/pull/42#discussion_r419500026
##########
File path: cibuild.sh
##########
@@ -48,6 +48,14 @@ function python-tools {
PYTHONUSERBASE=$prebuilt/pylocal
export PYTHONUSERBASE
add_path $PYTHONUSERBASE/bin
+ case $os in
+ Darwin)
+ PIP=pip3
Review comment:
we can find the regression quickly with ci, so let's keep the code clean as much as we can.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] liuguo09 commented on a change in pull request #42: Some cibuild.sh improvements
Posted by GitBox <gi...@apache.org>.
liuguo09 commented on a change in pull request #42:
URL: https://github.com/apache/incubator-nuttx-testing/pull/42#discussion_r420590308
##########
File path: cibuild.sh
##########
@@ -48,6 +48,14 @@ function python-tools {
PYTHONUSERBASE=$prebuilt/pylocal
export PYTHONUSERBASE
add_path $PYTHONUSERBASE/bin
+ case $os in
+ Darwin)
+ PIP=pip3
Review comment:
Just issue a jira to ask infra team to help: https://issues.apache.org/jira/browse/INFRA-20237.
There is still parallel build issue which could only be reproduced in apache build server with more powerful cpus. Once it's fixed, I think use github docker container to run the nightly build would be good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in pull request #42: Some cibuild.sh improvements
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #42:
URL: https://github.com/apache/incubator-nuttx-testing/pull/42#discussion_r419429172
##########
File path: cibuild.sh
##########
@@ -289,6 +291,8 @@ function install_tools {
$func
done
popd
+
+ echo PATH=$EXTRA_PATH\$PATH > $prebuilt/env.sh
Review comment:
Who will use this?
##########
File path: cibuild.sh
##########
@@ -48,6 +48,14 @@ function python-tools {
PYTHONUSERBASE=$prebuilt/pylocal
export PYTHONUSERBASE
add_path $PYTHONUSERBASE/bin
+ case $os in
+ Darwin)
+ PIP=pip3
Review comment:
Should we always use pip3?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] btashton commented on a change in pull request #42: Some cibuild.sh improvements
Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #42:
URL: https://github.com/apache/incubator-nuttx-testing/pull/42#discussion_r420534263
##########
File path: cibuild.sh
##########
@@ -48,6 +48,14 @@ function python-tools {
PYTHONUSERBASE=$prebuilt/pylocal
export PYTHONUSERBASE
add_path $PYTHONUSERBASE/bin
+ case $os in
+ Darwin)
+ PIP=pip3
Review comment:
I see that it would be fairly trivial to have it use our docker container to the build if that would be easier for us to maintain
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] btashton commented on a change in pull request #42: Some cibuild.sh improvements
Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #42:
URL: https://github.com/apache/incubator-nuttx-testing/pull/42#discussion_r420600770
##########
File path: cibuild.sh
##########
@@ -48,6 +48,14 @@ function python-tools {
PYTHONUSERBASE=$prebuilt/pylocal
export PYTHONUSERBASE
add_path $PYTHONUSERBASE/bin
+ case $os in
+ Darwin)
+ PIP=pip3
Review comment:
I'm not suggesting removing it, I'm just saying I can change the Jenkins config to run the container instead. It would still run the parallel job we just would have better control of the software on the host.
I don't have a strong opinion just wanted people to know it is an option
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] yamt commented on a change in pull request #42: Some cibuild.sh improvements
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #42:
URL: https://github.com/apache/incubator-nuttx-testing/pull/42#discussion_r419586594
##########
File path: cibuild.sh
##########
@@ -48,6 +48,14 @@ function python-tools {
PYTHONUSERBASE=$prebuilt/pylocal
export PYTHONUSERBASE
add_path $PYTHONUSERBASE/bin
+ case $os in
+ Darwin)
+ PIP=pip3
Review comment:
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] liuguo09 commented on a change in pull request #42: Some cibuild.sh improvements
Posted by GitBox <gi...@apache.org>.
liuguo09 commented on a change in pull request #42:
URL: https://github.com/apache/incubator-nuttx-testing/pull/42#discussion_r420532197
##########
File path: cibuild.sh
##########
@@ -48,6 +48,14 @@ function python-tools {
PYTHONUSERBASE=$prebuilt/pylocal
export PYTHONUSERBASE
add_path $PYTHONUSERBASE/bin
+ case $os in
+ Darwin)
+ PIP=pip3
Review comment:
The latest apache nightly build server build break without pip3 installed : (
./cibuild.sh: line 214: pip3: command not found
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org