Re: [PR] [opt](inverted index) Enhance I/O statistics collection for the inverted index in file cache scenarios [doris-thirdparty]

["airborne12 (via GitHub)" <gi...@apache.org>]

airborne12 commented on code in PR #295:
URL: https://github.com/apache/doris-thirdparty/pull/295#discussion_r1997861820


##########
src/core/CLucene/index/MultiReader.cpp:
##########
@@ -253,14 +253,18 @@ void MultiReader::doSetNorm(int32_t n, const TCHAR* field, uint8_t value){
 	(*subReaders)[i]->setNorm(n-starts[i], field, value); // dispatch
 }
 
-TermEnum* MultiReader::terms() {
+TermEnum* MultiReader::terms(const void* io_ctx) {
   ensureOpen();
-	return _CLNEW MultiTermEnum(subReaders, starts, NULL);
+	auto* ret = _CLNEW MultiTermEnum(subReaders, starts, NULL);

Review Comment:
   why not : 	return _CLNEW MultiTermEnum(subReaders, starts, io_ctx);
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org