You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by li...@apache.org on 2022/05/07 01:11:11 UTC
[servicecomb-java-chassis] branch master updated: [SCB-2482] Fix spotbugs UC_USELESS_OBJECT (#2823)
This is an automated email from the ASF dual-hosted git repository.
liubao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/servicecomb-java-chassis.git
The following commit(s) were added to refs/heads/master by this push:
new ae7007bde [SCB-2482] Fix spotbugs UC_USELESS_OBJECT (#2823)
ae7007bde is described below
commit ae7007bdeec24ed4e90388f3ef5fc04725de52d2
Author: ZhangJian He <sh...@gmail.com>
AuthorDate: Sat May 7 09:11:06 2022 +0800
[SCB-2482] Fix spotbugs UC_USELESS_OBJECT (#2823)
---
ci/spotbugs/exclude.xml | 4 ----
.../java/org/apache/servicecomb/foundation/vertx/VertxTLSBuilder.java | 2 --
2 files changed, 6 deletions(-)
diff --git a/ci/spotbugs/exclude.xml b/ci/spotbugs/exclude.xml
index e3a4c712a..19c487f13 100644
--- a/ci/spotbugs/exclude.xml
+++ b/ci/spotbugs/exclude.xml
@@ -167,10 +167,6 @@
<Bug pattern="SSD_DO_NOT_USE_INSTANCE_LOCK_ON_SHARED_STATIC_DATA"/>
</Match>
- <Match>
- <Bug pattern="UC_USELESS_OBJECT"/>
- </Match>
-
<Match>
<Bug pattern="URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD"/>
</Match>
diff --git a/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/VertxTLSBuilder.java b/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/VertxTLSBuilder.java
index 309057259..e1f84f962 100644
--- a/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/VertxTLSBuilder.java
+++ b/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/VertxTLSBuilder.java
@@ -110,8 +110,6 @@ public final class VertxTLSBuilder {
tcpClientOptions.setSsl(true);
if (sslOption.getEngine().equalsIgnoreCase("openssl")) {
- OpenSSLEngineOptions options = new OpenSSLEngineOptions();
- options.setSessionCacheEnabled(true);
tcpClientOptions.setOpenSslEngineOptions(new OpenSSLEngineOptions());
}
String fullKeyStore = sslCustom.getFullPath(sslOption.getKeyStore());