[GitHub] ivankelly commented on a change in pull request #738: Issue 731: refine LedgerEntry interface and implementation

[GitBox <gi...@apache.org>]

ivankelly commented on a change in pull request #738: Issue 731: refine LedgerEntry interface and implementation
URL: https://github.com/apache/bookkeeper/pull/738#discussion_r151649331
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/LedgerEntry.java
 ##########
 @@ -56,11 +56,9 @@
     long getLength();
 
     /**
-     * Returns the content of the entry. This method can be called only once. While using v2 wire protocol this method
-     * will automatically release the internal ByteBuf.
+     * Returns the content of the entry.
      *
      * @return the content of the entry
-     * @throws IllegalStateException if this method is called twice
      */
     byte[] getEntry();
 
 
 Review comment:
   Returning a ByteBuf should be consistent whether using the V2 wire protocol or not. As it is now, the documentation for getEntryBuffer is super confusing.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services