You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by gi...@git.apache.org on 2017/10/18 07:15:53 UTC

[GitHub] eolivelli closed pull request #638: Fix for BookKeeperBuildersTest

eolivelli closed pull request #638: Fix for BookKeeperBuildersTest
URL: https://github.com/apache/bookkeeper/pull/638
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/SyncCallbackUtils.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/SyncCallbackUtils.java
index 6b6c7d8b2..822d32756 100644
--- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/SyncCallbackUtils.java
+++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/SyncCallbackUtils.java
@@ -111,7 +111,7 @@ public SyncCreateAdvCallback(CompletableFuture<? super LedgerHandleAdv> future)
          */
         @Override
         public void createComplete(int rc, LedgerHandle lh, Object ctx) {
-            if (lh instanceof LedgerHandleAdv) {
+            if (lh == null || lh instanceof LedgerHandleAdv) {
                 finish(rc, (LedgerHandleAdv) lh, future);
             } else {
                 finish(BKException.Code.UnexpectedConditionException, null, future);
@@ -312,4 +312,4 @@ public void closeComplete(int rc, LedgerHandle lh, Object ctx) {
         }
     }
 
-}
\ No newline at end of file
+}


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services