You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "cserwen (via GitHub)" <gi...@apache.org> on 2023/02/14 08:38:08 UTC
[GitHub] [rocketmq-client-go] cserwen opened a new pull request, #1001: fix wrong add for set when tags are set
cserwen opened a new pull request, #1001:
URL: https://github.com/apache/rocketmq-client-go/pull/1001
## What is the purpose of the change
Fix bug from #962
When using tags, there are some problems in the `clone` method
## Brief changelog
XX
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] ferrirW commented on a diff in pull request #1001: fix wrong add for set when tags are set
Posted by "ferrirW (via GitHub)" <gi...@apache.org>.
ferrirW commented on code in PR #1001:
URL: https://github.com/apache/rocketmq-client-go/pull/1001#discussion_r1178929560
##########
internal/model.go:
##########
@@ -73,15 +73,15 @@ func (sd *SubscriptionData) Clone() *SubscriptionData {
if sd.Tags.Items() != nil {
cloned.Tags = utils.NewSet()
- for _, value := range sd.Tags.Items() {
- cloned.Tags.Add(value)
+ for key, value := range sd.Tags.Items() {
+ cloned.Tags.AddKV(key, value.UniqueID())
Review Comment:
why value become uniqueId? @cserwen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] cserwen commented on a diff in pull request #1001: fix wrong add for set when tags are set
Posted by "cserwen (via GitHub)" <gi...@apache.org>.
cserwen commented on code in PR #1001:
URL: https://github.com/apache/rocketmq-client-go/pull/1001#discussion_r1178937746
##########
internal/model.go:
##########
@@ -73,15 +73,15 @@ func (sd *SubscriptionData) Clone() *SubscriptionData {
if sd.Tags.Items() != nil {
cloned.Tags = utils.NewSet()
- for _, value := range sd.Tags.Items() {
- cloned.Tags.Add(value)
+ for key, value := range sd.Tags.Items() {
+ cloned.Tags.AddKV(key, value.UniqueID())
Review Comment:
`Key` is the real tag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] cserwen commented on pull request #1001: fix wrong add for set when tags are set
Posted by "cserwen (via GitHub)" <gi...@apache.org>.
cserwen commented on PR #1001:
URL: https://github.com/apache/rocketmq-client-go/pull/1001#issuecomment-1522656084
@francisoliverlee Please help me to review it. This pr is important for subscribe with tags.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] cserwen merged pull request #1001: fix wrong add for set when tags are set
Posted by "cserwen (via GitHub)" <gi...@apache.org>.
cserwen merged PR #1001:
URL: https://github.com/apache/rocketmq-client-go/pull/1001
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org