Re: [PR] Core: Properly suppress historical snapshots when building TableMetadata with suppressHistoricalSnapshots() [iceberg]

["nastra (via GitHub)" <gi...@apache.org>]

nastra commented on code in PR #9234:
URL: https://github.com/apache/iceberg/pull/9234#discussion_r1422341041


##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -1384,7 +1386,9 @@ public Builder setPreviousFileLocation(String previousFileLocation) {
     private boolean hasChanges() {
       return changes.size() != startingChangeCount
           || (discardChanges && !changes.isEmpty())
-          || metadataLocation != null;
+          || metadataLocation != null
+          || suppressHistoricalSnapshots

Review Comment:
   this is for the server-side to indicate that there are changes



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org