[jira] [Updated] (HBASE-14902) Revert some of the stringency recently introduced by checkstyle tightening

["stack (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HBASE-14902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-14902:
--------------------------
    Attachment: 14902.patch

Suggested patch. What you think [~appy]?

Do we need a writeup somewhere on the recent checkstyle changes? For instance, I did not know about the diff created by a patch  now is dumped in console output (any chance of adding line numbers to this dump or is that too much). And would be good to find a note that rather than '@throw IOException', we suggest just remove the javadoc since it adds nothing.

> Revert some of the stringency recently introduced by checkstyle tightening
> --------------------------------------------------------------------------
>
>                 Key: HBASE-14902
>                 URL: https://issues.apache.org/jira/browse/HBASE-14902
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: stack
>             Fix For: 2.0.0
>
>         Attachments: 14902.patch
>
>
> I think we should undo some of the plugins that were recently added to checkstyle. They are too much.
> JavadocTagContinuationIndentationCheck is about adding indent if javadoc is two lines or more (javadoc tool doesn't care)
> NonEmptyAtclauseDescriptionCheck would have us add javadoc on each exception: e.g. @throws IOException needs to have text added.
> NeedBracesCheck has us undoing cases where an if fits all on one line (don't want to start style wars but if short and fits on one line, I think its more readable... but I could relent on this one.... ).
> The first two at least should go.
> You ok w/ that [~appy]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)