You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/12/01 08:27:15 UTC

[GitHub] [pulsar] xuesongxs opened a new issue #8759: If allowAutoTopicCreation enabled in broker, the same subscriber name will conflict under different non-partitioned topics

xuesongxs opened a new issue #8759:
URL: https://github.com/apache/pulsar/issues/8759


   **Describe the bug**
   Consumer code:
               Consumer<String> consumer = getClient().newConsumer(Schema.STRING)
                       .topic("persistent://public/default/test-string2")
                       .subscriptionType(SubscriptionType.Shared)
                       .subscriptionName("my-subscription32")
                       .enableRetry(true)
                       .deadLetterPolicy(DeadLetterPolicy.builder()
                               .maxRedeliverCount(3)
                               .build())
                       .subscribe();
   
   I created two non-partitioned topics: test-string2, test-string3。
   The name of the subscription is the same，allowAutoTopicCreation=true，and allowAutoTopicCreationType=non-partitioned，in broker, both consumers will write messages to my-subscription32-DLQ.
   The automatically created topic formart is not: topic-subscriptionName-DLQ，it is subscriptionName-DLQ.
   
   
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] 315157973 commented on issue #8759: DeadLetterPolicy, If allowAutoTopicCreation enabled in broker, the same subscriber name will conflict under different non-partitioned topics

Posted by GitBox <gi...@apache.org>.
315157973 commented on issue #8759:
URL: https://github.com/apache/pulsar/issues/8759#issuecomment-737695451


   Fixing this issue is simple. But if we modify the rules of name generation when DLQ is automatically created, there will be backward compatibility issues. So it needs to be discussed.
   
   The current generation rules are as follows:
   ```Java
   String deadLetterTopic = topicFirst.getNamespace() + "/" 
   + conf.getSubscriptionName() + RetryMessageUtil.DLQ_GROUP_TOPIC_SUFFIX;
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] mattisonchao commented on issue #8759: DeadLetterPolicy, If allowAutoTopicCreation enabled in broker, the same subscriber name will conflict under different non-partitioned topics

Posted by GitBox <gi...@apache.org>.
mattisonchao commented on issue #8759:
URL: https://github.com/apache/pulsar/issues/8759#issuecomment-968927875


   This issue has been fixed by #10129 , I think we should close this issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] 315157973 commented on issue #8759: DeadLetterPolicy, If allowAutoTopicCreation enabled in broker, the same subscriber name will conflict under different non-partitioned topics

Posted by GitBox <gi...@apache.org>.
315157973 commented on issue #8759:
URL: https://github.com/apache/pulsar/issues/8759#issuecomment-737675267


   I will fix it


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui closed issue #8759: DeadLetterPolicy, If allowAutoTopicCreation enabled in broker, the same subscriber name will conflict under different non-partitioned topics

Posted by GitBox <gi...@apache.org>.
codelipenghui closed issue #8759:
URL: https://github.com/apache/pulsar/issues/8759


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org