You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/24 08:21:48 UTC

[GitHub] [arrow] kszucs commented on a diff in pull request #13149: ARROW-16403:[R][CI] Create Crossbow task for R nightly builds

kszucs commented on code in PR #13149:
URL: https://github.com/apache/arrow/pull/13149#discussion_r880206705


##########
dev/tasks/macros.jinja:
##########
@@ -221,3 +222,79 @@ on:
         cp ${formula} $(brew --repository homebrew/core)/Formula/
       done
 {% endmacro %}
+
+{%- macro change_r_pkg_version(is_fork, version = '\\2.\'\"$(date +%Y%m%d)\"\'' ) -%}

Review Comment:
   Could you prefix the macros with `github_` so it's clear that they only work on GHA.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org