You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/06/06 15:37:40 UTC

[GitHub] [commons-math] bhawna94 opened a new pull request #146: Simplify condition for if and conditional operator

bhawna94 opened a new pull request #146:
URL: https://github.com/apache/commons-math/pull/146


   This PR consists of the following changes:
   - Simplify if condition
   - Simplify condition mentioned in the conditional operator


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-math] bhawna94 commented on pull request #146: Simplify if condition

Posted by GitBox <gi...@apache.org>.
bhawna94 commented on pull request #146:
URL: https://github.com/apache/commons-math/pull/146#issuecomment-647728065


   Oh okay 😅  i thought they had closed the PR without merging. My bad!! Btw thanks for all your assistance. @XenoAmess


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-math] XenoAmess commented on pull request #146: Simplify if condition

Posted by GitBox <gi...@apache.org>.
XenoAmess commented on pull request #146:
URL: https://github.com/apache/commons-math/pull/146#issuecomment-647650646


   @bhawna94
   sometimes they close it instead of merge due to some git reason. 
   If they close with a commit then the commit might be your commit. this time it is https://github.com/apache/commons-math/commit/0d937abf8ca9878aadc1b4e62e333976e74e8942


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-math] bhawna94 commented on pull request #146: Simplify if condition

Posted by GitBox <gi...@apache.org>.
bhawna94 commented on pull request #146:
URL: https://github.com/apache/commons-math/pull/146#issuecomment-647708419


   Thanks @XenoAmess for the information. What should i do now? I cant reopen this PR. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-math] kinow commented on pull request #146: Simplify if condition

Posted by GitBox <gi...@apache.org>.
kinow commented on pull request #146:
URL: https://github.com/apache/commons-math/pull/146#issuecomment-647407576


   Sorry @bhawna94 I am away from my computer, approved from my mobile. The changes appear to be in source code, and not only for tests. Would you mind creating an issue for this PR, please? I will take care to update changelog and merge it later this week :+1: 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-math] bhawna94 edited a comment on pull request #146: Simplify if condition

Posted by GitBox <gi...@apache.org>.
bhawna94 edited a comment on pull request #146:
URL: https://github.com/apache/commons-math/pull/146#issuecomment-645163584


   @olamy @epugh @jukka @dims @brettporter @asfgit @jodastephen @jfclere 
   Could you please review the PR and let me know your thoughts


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-math] XenoAmess commented on pull request #146: Simplify if condition

Posted by GitBox <gi...@apache.org>.
XenoAmess commented on pull request #146:
URL: https://github.com/apache/commons-math/pull/146#issuecomment-645806014


   @bhawna94 Hi. I'm not any official guy of this repo so calling me is pointless...
   also, @asfgit is just a robot for sync so calling him is pointless either...
   btw I feel neutral about this pr, it looks slightly better than origion, but seems not change anything output.
   so I vote +0.5 here.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-math] bhawna94 edited a comment on pull request #146: Simplify if condition

Posted by GitBox <gi...@apache.org>.
bhawna94 edited a comment on pull request #146:
URL: https://github.com/apache/commons-math/pull/146#issuecomment-647599111


   > Sorry @bhawna94 I am away from my computer, approved from my mobile. The changes appear to be in source code, and not only for tests. Would you mind creating an issue for this PR, please? I will take care to update changelog and merge it later this week  (probably tomorrow at lunch break if not too busy, or maybe once I get home)
   
   Any reason for closing this PR? I am not able to reopen it again. @kinow 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-math] bhawna94 edited a comment on pull request #146: Simplify if condition

Posted by GitBox <gi...@apache.org>.
bhawna94 edited a comment on pull request #146:
URL: https://github.com/apache/commons-math/pull/146#issuecomment-647599111


   > Sorry @bhawna94 I am away from my computer, approved from my mobile. The changes appear to be in source code, and not only for tests. Would you mind creating an issue for this PR, please? I will take care to update changelog and merge it later this week  (probably tomorrow at lunch break if not too busy, or maybe once I get home)
   
   Any reason for closing this PR? I am not able to reopen it again. @kinow Could you please reopen it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-math] bhawna94 edited a comment on pull request #146: Simplify if condition

Posted by GitBox <gi...@apache.org>.
bhawna94 edited a comment on pull request #146:
URL: https://github.com/apache/commons-math/pull/146#issuecomment-645163584


   @olamy @epugh @jukka @dims @brettporter @asfgit @efge @chentao106 
   Could you please review the PR and let me know your thoughts


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-math] ayushhooda commented on pull request #146: Simplify if condition

Posted by GitBox <gi...@apache.org>.
ayushhooda commented on pull request #146:
URL: https://github.com/apache/commons-math/pull/146#issuecomment-645281433


   @jochenw It seems to be very much correct. ! Operator is nothing but a shorthand for false condition


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-math] XenoAmess edited a comment on pull request #146: Simplify if condition

Posted by GitBox <gi...@apache.org>.
XenoAmess edited a comment on pull request #146:
URL: https://github.com/apache/commons-math/pull/146#issuecomment-647722091


   > Thanks @XenoAmess for the information. What should i do now? I cant reopen this PR.
   
   you needn't. this pr is already merged. lol
   you can see more details in https://github.com/apache/commons-math/commits/master , your commit is in there now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-math] bhawna94 edited a comment on pull request #146: Simplify if condition

Posted by GitBox <gi...@apache.org>.
bhawna94 edited a comment on pull request #146:
URL: https://github.com/apache/commons-math/pull/146#issuecomment-645163584


   @olamy @epugh @jukka @dims @brettporter @asfgit @efge @chentao106 @XenoAmess
   Could you please review the PR and let me know your thoughts


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-math] bhawna94 commented on pull request #146: Simplify if condition

Posted by GitBox <gi...@apache.org>.
bhawna94 commented on pull request #146:
URL: https://github.com/apache/commons-math/pull/146#issuecomment-645864577


   Thanks @jochnew do we need other approvals also to merge the PR? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-math] XenoAmess commented on pull request #146: Simplify if condition

Posted by GitBox <gi...@apache.org>.
XenoAmess commented on pull request #146:
URL: https://github.com/apache/commons-math/pull/146#issuecomment-647722091


   > Thanks @XenoAmess for the information. What should i do now? I cant reopen this PR.
   
   you needn't. this pr is already merged. lol


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-math] XenoAmess edited a comment on pull request #146: Simplify if condition

Posted by GitBox <gi...@apache.org>.
XenoAmess edited a comment on pull request #146:
URL: https://github.com/apache/commons-math/pull/146#issuecomment-645816424






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-math] coveralls commented on pull request #146: Simplify condition for if and conditional operator

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #146:
URL: https://github.com/apache/commons-math/pull/146#issuecomment-640087154


   
   [![Coverage Status](https://coveralls.io/builds/31284249/badge)](https://coveralls.io/builds/31284249)
   
   Coverage increased (+0.008%) to 90.564% when pulling **712b9ac7c72aeffdc395e084d6b5fea9ae57c0e6 on bhawna94:simplify-condition** into **ba8a26705e7656201951ddc1a4a67c6aaa62d146 on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-math] bhawna94 edited a comment on pull request #146: Simplify if condition

Posted by GitBox <gi...@apache.org>.
bhawna94 edited a comment on pull request #146:
URL: https://github.com/apache/commons-math/pull/146#issuecomment-645864577


   Thanks @jochenw do we need other approvals also to merge the PR? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-math] bhawna94 edited a comment on pull request #146: Simplify if condition

Posted by GitBox <gi...@apache.org>.
bhawna94 edited a comment on pull request #146:
URL: https://github.com/apache/commons-math/pull/146#issuecomment-645163584


   @olamy @epugh @jukka @dims @brettporter @asfgit 
   Could you please review the PR and let me know your thoughts


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-math] bhawna94 edited a comment on pull request #146: Simplify if condition

Posted by GitBox <gi...@apache.org>.
bhawna94 edited a comment on pull request #146:
URL: https://github.com/apache/commons-math/pull/146#issuecomment-647283170


   > Thanks!
   
   Are we good to merge this PR now?
   @kinow 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-math] coveralls edited a comment on pull request #146: Simplify condition for if and conditional operator

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #146:
URL: https://github.com/apache/commons-math/pull/146#issuecomment-640087154


   
   [![Coverage Status](https://coveralls.io/builds/31284329/badge)](https://coveralls.io/builds/31284329)
   
   Coverage remained the same at 90.556% when pulling **e13525f77056f99345b121fe4e8e81fc5fcfa43f on bhawna94:simplify-condition** into **ba8a26705e7656201951ddc1a4a67c6aaa62d146 on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-math] coveralls edited a comment on pull request #146: Simplify if condition

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #146:
URL: https://github.com/apache/commons-math/pull/146#issuecomment-640087154


   
   [![Coverage Status](https://coveralls.io/builds/31592449/badge)](https://coveralls.io/builds/31592449)
   
   Coverage remained the same at 90.554% when pulling **6d8f8183818d753efc3bc6a25622298a114afb70 on bhawna94:simplify-condition** into **bfa5b60eff89ef75fabd5fbd53e61c56b4b65566 on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-math] bhawna94 commented on pull request #146: Simplify if condition

Posted by GitBox <gi...@apache.org>.
bhawna94 commented on pull request #146:
URL: https://github.com/apache/commons-math/pull/146#issuecomment-640587209


   @olamy @epugh @jukka 
   I think we can simplify these if conditions.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-math] bhawna94 commented on pull request #146: Simplify if condition

Posted by GitBox <gi...@apache.org>.
bhawna94 commented on pull request #146:
URL: https://github.com/apache/commons-math/pull/146#issuecomment-647599111


   > Sorry @bhawna94 I am away from my computer, approved from my mobile. The changes appear to be in source code, and not only for tests. Would you mind creating an issue for this PR, please? I will take care to update changelog and merge it later this week  (probably tomorrow at lunch break if not too busy, or maybe once I get home)
   
   Any reason for closing this PR? I am not able to reopen it again.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-math] bhawna94 edited a comment on pull request #146: Simplify if condition

Posted by GitBox <gi...@apache.org>.
bhawna94 edited a comment on pull request #146:
URL: https://github.com/apache/commons-math/pull/146#issuecomment-647283170


   > Thanks!
   
   Please let me know how many approvals we need to merge this PR.
   @kinow 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-math] bhawna94 commented on pull request #146: Simplify if condition

Posted by GitBox <gi...@apache.org>.
bhawna94 commented on pull request #146:
URL: https://github.com/apache/commons-math/pull/146#issuecomment-645163584


   @olamy @epugh @jukka 
   Could you please review the PR and let me know your thoughts


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-math] bhawna94 commented on pull request #146: Simplify if condition

Posted by GitBox <gi...@apache.org>.
bhawna94 commented on pull request #146:
URL: https://github.com/apache/commons-math/pull/146#issuecomment-647283170


   > Thanks!
   
   Please let me know how many approvals we need to merge this PR.
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-math] bhawna94 edited a comment on pull request #146: Simplify if condition

Posted by GitBox <gi...@apache.org>.
bhawna94 edited a comment on pull request #146:
URL: https://github.com/apache/commons-math/pull/146#issuecomment-645163584


   @olamy @epugh @jukka @dims @brettporter @efge @chentao106 @XenoAmess
   Could you please review the PR and let me know your thoughts


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-math] XenoAmess commented on pull request #146: Simplify if condition

Posted by GitBox <gi...@apache.org>.
XenoAmess commented on pull request #146:
URL: https://github.com/apache/commons-math/pull/146#issuecomment-645816424


   > @XenoAmess So could you please help me out in knowing the right person who can review the PR.
   
   Gilles Sadowski seems the most active official committer in this repo.
   But he do not use github...
   If you wanna call him you'd better send a mail in the mailing list of commons dev, or create a JIRA ticket for this pr in JIRA https://issues.apache.org/jira/


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-math] bhawna94 edited a comment on pull request #146: Simplify if condition

Posted by GitBox <gi...@apache.org>.
bhawna94 edited a comment on pull request #146:
URL: https://github.com/apache/commons-math/pull/146#issuecomment-645163584


   @olamy @epugh @jukka @dims @brettporter @asfgit @efge
   Could you please review the PR and let me know your thoughts


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-math] bhawna94 edited a comment on pull request #146: Simplify if condition

Posted by GitBox <gi...@apache.org>.
bhawna94 edited a comment on pull request #146:
URL: https://github.com/apache/commons-math/pull/146#issuecomment-640587209


   @olamy 
   I think we can simplify these if conditions.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-math] bhawna94 edited a comment on pull request #146: Simplify if condition

Posted by GitBox <gi...@apache.org>.
bhawna94 edited a comment on pull request #146:
URL: https://github.com/apache/commons-math/pull/146#issuecomment-647708419


   Thanks @XenoAmess for the information. What should i do now? Is the Pr merged or should i reopen it?  


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-math] XenoAmess edited a comment on pull request #146: Simplify if condition

Posted by GitBox <gi...@apache.org>.
XenoAmess edited a comment on pull request #146:
URL: https://github.com/apache/commons-math/pull/146#issuecomment-645816424


   > @XenoAmess So could you please help me out in knowing the right person who can review the PR.
   
   @bhawna94
   
   Gilles Sadowski seems the most active official committer in this repo.
   But he does not use github...
   If you wanna call him you'd better send a mail in the mailing list of commons dev, or create a JIRA ticket for this pr in JIRA https://issues.apache.org/jira/


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-math] bhawna94 commented on pull request #146: Simplify if condition

Posted by GitBox <gi...@apache.org>.
bhawna94 commented on pull request #146:
URL: https://github.com/apache/commons-math/pull/146#issuecomment-647257476


   > Looks good to me. @bhawna94 as Gilles pointed out in the mailing list, these commits can be squashed into a single one, so that it's easier to revert or navigate through these commits should another developer needs to  could you update the PR with that change, please?
   
   Squashed the commit into a single commit.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-math] bhawna94 commented on pull request #146: Simplify if condition

Posted by GitBox <gi...@apache.org>.
bhawna94 commented on pull request #146:
URL: https://github.com/apache/commons-math/pull/146#issuecomment-645284882


   Exactly @ayushhooda 
   I am using shorthand here for the false condition.
   @jochenw Both the things are identical 
   **object instanceof Foo == false**   
   and **!(object instanceof Foo)**


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-math] bhawna94 commented on pull request #146: Simplify if condition

Posted by GitBox <gi...@apache.org>.
bhawna94 commented on pull request #146:
URL: https://github.com/apache/commons-math/pull/146#issuecomment-645812981


   @XenoAmess So could you please help me out in knowing the right person who can review the PR.  


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-math] kinow commented on pull request #146: Simplify if condition

Posted by GitBox <gi...@apache.org>.
kinow commented on pull request #146:
URL: https://github.com/apache/commons-math/pull/146#issuecomment-647281455


   Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-math] kinow edited a comment on pull request #146: Simplify if condition

Posted by GitBox <gi...@apache.org>.
kinow edited a comment on pull request #146:
URL: https://github.com/apache/commons-math/pull/146#issuecomment-647407576


   Sorry @bhawna94 I am away from my computer, approved from my mobile. The changes appear to be in source code, and not only for tests. Would you mind creating an issue for this PR, please? I will take care to update changelog and merge it later this week :+1: (probably tomorrow at lunch break if not too busy, or maybe once I get home)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-math] asfgit closed pull request #146: Simplify if condition

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #146:
URL: https://github.com/apache/commons-math/pull/146


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-math] bhawna94 edited a comment on pull request #146: Simplify if condition

Posted by GitBox <gi...@apache.org>.
bhawna94 edited a comment on pull request #146:
URL: https://github.com/apache/commons-math/pull/146#issuecomment-645163584


   @olamy @epugh @jukka @dims @brettporter @asfgit 
   Could you please review the PR and let me know your thoughts


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org