You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/07/29 20:58:31 UTC

[GitHub] [iceberg] kbendick commented on pull request #5377: Spark - Add Spark FunctionCatalog

kbendick commented on PR #5377:
URL: https://github.com/apache/iceberg/pull/5377#issuecomment-1199940719

   I ran coverage.
   
   The changes I made in:
   - `BaseCatalog` - 100% for both methods and lines
   - `SparkFunctions` - 100% across the board
   - `IcebergVersionFunction` - 100% for methods and classes, but 87% for lines (not tests for calling `bind` with arguments).
   
   I figure since we didn't really want to test `bind` much anyway that that's fine.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org