You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by GitBox <gi...@apache.org> on 2020/09/26 10:34:33 UTC
[GitHub] [ofbiz-framework] yashwantdhakad opened a new pull request #235: OFBIZ-11855 Improved: Convert RoutingServices.xml mini lang to groovy.
yashwantdhakad opened a new pull request #235:
URL: https://github.com/apache/ofbiz-framework/pull/235
OFBIZ-11855 Improved: Convert RoutingServices.xml mini lang to groovy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-framework] mbrohl commented on pull request #235: OFBIZ-11855 Improved: Convert RoutingServices.xml mini lang to groovy.
Posted by GitBox <gi...@apache.org>.
mbrohl commented on pull request #235:
URL: https://github.com/apache/ofbiz-framework/pull/235#issuecomment-773454621
Hi @yashwantdhakad ,
thanks for your contribution. There are some pull request merges included which do not seem do be related to the Minilan/Groovy conversion. Can you please provide a clean PR which only contains the intended changes based on latest trunk?
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-framework] yashwantdhakad closed pull request #235: OFBIZ-11855 Improved: Convert RoutingServices.xml mini lang to groovy.
Posted by GitBox <gi...@apache.org>.
yashwantdhakad closed pull request #235:
URL: https://github.com/apache/ofbiz-framework/pull/235
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-framework] yashwantdhakad commented on pull request #235: OFBIZ-11855 Improved: Convert RoutingServices.xml mini lang to groovy.
Posted by GitBox <gi...@apache.org>.
yashwantdhakad commented on pull request #235:
URL: https://github.com/apache/ofbiz-framework/pull/235#issuecomment-920594788
Closing this PR, I have provided the patch and the changes already merged in the trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-framework] mbrohl commented on pull request #235: OFBIZ-11855 Improved: Convert RoutingServices.xml mini lang to groovy.
Posted by GitBox <gi...@apache.org>.
mbrohl commented on pull request #235:
URL: https://github.com/apache/ofbiz-framework/pull/235#issuecomment-773454621
Hi @yashwantdhakad ,
thanks for your contribution. There are some pull request merges included which do not seem do be related to the Minilan/Groovy conversion. Can you please provide a clean PR which only contains the intended changes based on latest trunk?
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #235: OFBIZ-11855 Improved: Convert RoutingServices.xml mini lang to groovy.
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #235:
URL: https://github.com/apache/ofbiz-framework/pull/235#issuecomment-699477360
Kudos, SonarCloud Quality Gate passed!
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=235&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=235&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=235&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=235&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=235&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=235&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=235&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issue
s?id=apache_ofbiz-framework&pullRequest=235&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=235&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=235&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=235&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=235) No Coverage information
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=235&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=235&metric=new_duplicated_lines_density&view=list)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org