[GitHub] [tinkerpop] spmallette commented on pull request #1374: Vertex and Edge's properties in graphbinary serialization

[GitBox <gi...@apache.org>]

spmallette commented on pull request #1374:
URL: https://github.com/apache/tinkerpop/pull/1374#issuecomment-748455260


   GraphBinary was specifically built as a network serialization format whereas kryo/graphson play the double role of network and file serialization. We might have already removed properties from the latter if it didn't break the file serialization role. Note that by default neither of those serialization formats return properties anyway (at least in Gremlin Server as of 3.4.0) as graph elements are converted to references before serialization occurs.  So, even if GraphBinary suddenly started to have property serialization it wouldn't have anything to serialize. Note that Gryo is likely retired as a network serialization format so I don't imagine we'll change anything there ever and GraphSON is likely supplanted by GraphBinary for network serialization so I don't see much need to make changes to either of those for this purpose going forward.
   
   Speaking specifically to that statement, item 5, that you referenced. I was largely pointing out that we were hedging our bets a bit by leaving space for properties in the future, but I'm quite against adding them in isolation without wider thought/discussion to all the other issues in that email. I hope that answers your question.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org