[GitHub] [trafficserver] masaori335 commented on a diff in pull request #9141: Remove deprecated ld option (--add-needed)

[GitBox <gi...@apache.org>]

masaori335 commented on code in PR #9141:
URL: https://github.com/apache/trafficserver/pull/9141#discussion_r994256000


##########
build/jemalloc.m4:
##########
@@ -58,7 +58,7 @@ if test "$has_jemalloc" != "no"; then
   if test "$jemalloc_base_dir" != "/usr"; then
     TS_ADDTO(CPPFLAGS, [-I${jemalloc_include}])
     TS_ADDTO(LDFLAGS, [-L${jemalloc_ldflags}])
-    TS_ADDTO(LDFLAGS, [-Wl,--add-needed -L${jemalloc_ldflags} -Wl,-rpath,${jemalloc_ldflags} -Wl,--no-as-needed])

Review Comment:
   @duke8253 is this typo of `--as-needed` option? Because this line has `--no-as-needed` option at the end and it restores the default behavior.
   
   If we really need `--add-needed` option here, `--copy-dt-needed-entries` is the replacement, but `lld` doesn't have it either.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org