You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/12/06 14:09:39 UTC

[GitHub] [commons-crypto] garydgregory commented on a change in pull request #114: [CRYPTO-151] - Migrate to Junit 5

garydgregory commented on a change in pull request #114:
URL: https://github.com/apache/commons-crypto/pull/114#discussion_r537046441



##########
File path: src/test/java/org/apache/commons/crypto/stream/PositionedCryptoInputStreamTest.java
##########
@@ -247,7 +250,7 @@ private void testSeekFailed(final String cipherClass, final int position, final
                 getCipher(cipherClass), bufferSize);
         try {
             in.seek(position);
-            Assert.fail("Excepted exception for cannot seek to negative offset.");
+            fail("Excepted exception for cannot seek to negative offset.");
         } catch (final IllegalArgumentException iae) {

Review comment:
       Hi @arturobernalg 
   Thank you for your PR.
   If we go to JUnit 5, then let's remove this pattern with `assertThrows()`
   WDYT?
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org