You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/08/31 21:00:53 UTC

[GitHub] [kafka] vvcephei opened a new pull request #9234: MINOR: Record all poll invocations

vvcephei opened a new pull request #9234:
URL: https://github.com/apache/kafka/pull/9234


   Record the `pollSensor` after every invocation to poll, rather than just when we get records back so that we can accurately gauge how often we're invoking Consumer#poll.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] guozhangwang commented on pull request #9234: MINOR: Record all poll invocations

Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #9234:
URL: https://github.com/apache/kafka/pull/9234#issuecomment-686177562


   LGTM!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] vvcephei commented on pull request #9234: MINOR: Record all poll invocations

Posted by GitBox <gi...@apache.org>.
vvcephei commented on pull request #9234:
URL: https://github.com/apache/kafka/pull/9234#issuecomment-686708045


   The build passed for me, and it doesn't seem possible to add existing PRs to the new PR-builder job, so I've just merged it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] vvcephei commented on pull request #9234: MINOR: Record all poll invocations

Posted by GitBox <gi...@apache.org>.
vvcephei commented on pull request #9234:
URL: https://github.com/apache/kafka/pull/9234#issuecomment-684038074


   Hey @guozhangwang and @cadonna , I was just looking into key metrics for monitoring, and it seems like this metric is misplaced. Unlike the `pollRecordsSensor`, it seems like the `pollSensor` should be recorded unconditionally. WDYT?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] vvcephei merged pull request #9234: MINOR: Record all poll invocations

Posted by GitBox <gi...@apache.org>.
vvcephei merged pull request #9234:
URL: https://github.com/apache/kafka/pull/9234


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] vvcephei commented on pull request #9234: MINOR: Record all poll invocations

Posted by GitBox <gi...@apache.org>.
vvcephei commented on pull request #9234:
URL: https://github.com/apache/kafka/pull/9234#issuecomment-685946978


   Retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] vvcephei commented on pull request #9234: MINOR: Record all poll invocations

Posted by GitBox <gi...@apache.org>.
vvcephei commented on pull request #9234:
URL: https://github.com/apache/kafka/pull/9234#issuecomment-685944151


   Thanks, all!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org