You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jojy Varghese <jo...@mesosphere.io> on 2015/09/23 21:41:31 UTC
Re: Review Request 38654: Added digest verifier for image blobs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38654/
-----------------------------------------------------------
(Updated Sept. 23, 2015, 7:41 p.m.)
Review request for mesos, Gilbert Song and Timothy Chen.
Changes
-------
templatized the implementation.
Repository: mesos
Description
-------
Provides interface for verifying a blob of data for its digest and given digest type.
Diffs (updated)
-----
src/Makefile.am 2286366852b272c808490b6bd87ac9e894de57ac
src/slave/containerizer/provisioner/verifier/digest_verifier.hpp PRE-CREATION
src/tests/containerizer/provisioner_docker_tests.cpp 1b0c30450a07d01d1a38d460bc7d921c80be7e3b
Diff: https://reviews.apache.org/r/38654/diff/
Testing
-------
Thanks,
Jojy Varghese
Re: Review Request 38654: Added digest verifier for image blobs
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38654/#review100517
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38443, 38579, 38580, 38654]
All tests passed.
- Mesos ReviewBot
On Sept. 25, 2015, 12:38 a.m., Jojy Varghese wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38654/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2015, 12:38 a.m.)
>
>
> Review request for mesos, Gilbert Song and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provides interface for verifying a blob of data for its digest and given digest type.
>
>
> Diffs
> -----
>
> src/Makefile.am 2286366852b272c808490b6bd87ac9e894de57ac
> src/slave/containerizer/provisioner/verifier/digest_verifier.hpp PRE-CREATION
> src/tests/containerizer/provisioner_docker_tests.cpp 1b0c30450a07d01d1a38d460bc7d921c80be7e3b
>
> Diff: https://reviews.apache.org/r/38654/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jojy Varghese
>
>
Re: Review Request 38654: Added digest verifier for image blobs
Posted by Jojy Varghese <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38654/
-----------------------------------------------------------
(Updated Oct. 23, 2015, 5:31 p.m.)
Review request for mesos, Gilbert Song and Timothy Chen.
Repository: mesos
Description
-------
Provides interface for verifying a blob of data for its digest and given digest type.
Diffs
-----
src/Makefile.am 2286366852b272c808490b6bd87ac9e894de57ac
src/slave/containerizer/provisioner/verifier/digest_verifier.hpp PRE-CREATION
src/tests/containerizer/provisioner_docker_tests.cpp 1b0c30450a07d01d1a38d460bc7d921c80be7e3b
Diff: https://reviews.apache.org/r/38654/diff/
Testing
-------
Thanks,
Jojy Varghese
Re: Review Request 38654: Added digest verifier for image blobs
Posted by Jojy Varghese <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38654/
-----------------------------------------------------------
(Updated Oct. 23, 2015, 5:30 p.m.)
Review request for mesos, Gilbert Song and Timothy Chen.
Repository: mesos
Description
-------
Provides interface for verifying a blob of data for its digest and given digest type.
Diffs
-----
src/Makefile.am 2286366852b272c808490b6bd87ac9e894de57ac
src/slave/containerizer/provisioner/verifier/digest_verifier.hpp PRE-CREATION
src/tests/containerizer/provisioner_docker_tests.cpp 1b0c30450a07d01d1a38d460bc7d921c80be7e3b
Diff: https://reviews.apache.org/r/38654/diff/
Testing
-------
Thanks,
Jojy Varghese
Re: Review Request 38654: Added digest verifier for image blobs
Posted by Jojy Varghese <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38654/
-----------------------------------------------------------
(Updated Sept. 25, 2015, 12:38 a.m.)
Review request for mesos, Gilbert Song and Timothy Chen.
Changes
-------
added file digest.
Repository: mesos
Description
-------
Provides interface for verifying a blob of data for its digest and given digest type.
Diffs (updated)
-----
src/Makefile.am 2286366852b272c808490b6bd87ac9e894de57ac
src/slave/containerizer/provisioner/verifier/digest_verifier.hpp PRE-CREATION
src/tests/containerizer/provisioner_docker_tests.cpp 1b0c30450a07d01d1a38d460bc7d921c80be7e3b
Diff: https://reviews.apache.org/r/38654/diff/
Testing
-------
Thanks,
Jojy Varghese
Re: Review Request 38654: Added digest verifier for image blobs
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38654/#review100315
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38443, 38579, 38580, 38654]
All tests passed.
- Mesos ReviewBot
On Sept. 23, 2015, 10:27 p.m., Jojy Varghese wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38654/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2015, 10:27 p.m.)
>
>
> Review request for mesos, Gilbert Song and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provides interface for verifying a blob of data for its digest and given digest type.
>
>
> Diffs
> -----
>
> src/Makefile.am 2286366852b272c808490b6bd87ac9e894de57ac
> src/slave/containerizer/provisioner/verifier/digest_verifier.hpp PRE-CREATION
> src/tests/containerizer/provisioner_docker_tests.cpp 1b0c30450a07d01d1a38d460bc7d921c80be7e3b
>
> Diff: https://reviews.apache.org/r/38654/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jojy Varghese
>
>
Re: Review Request 38654: Added digest verifier for image blobs
Posted by Jojy Varghese <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38654/
-----------------------------------------------------------
(Updated Sept. 23, 2015, 10:27 p.m.)
Review request for mesos, Gilbert Song and Timothy Chen.
Changes
-------
added facade for verify and digest.
Repository: mesos
Description
-------
Provides interface for verifying a blob of data for its digest and given digest type.
Diffs (updated)
-----
src/Makefile.am 2286366852b272c808490b6bd87ac9e894de57ac
src/slave/containerizer/provisioner/verifier/digest_verifier.hpp PRE-CREATION
src/tests/containerizer/provisioner_docker_tests.cpp 1b0c30450a07d01d1a38d460bc7d921c80be7e3b
Diff: https://reviews.apache.org/r/38654/diff/
Testing
-------
Thanks,
Jojy Varghese
Re: Review Request 38654: Added digest verifier for image blobs
Posted by Jojy Varghese <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38654/
-----------------------------------------------------------
(Updated Sept. 23, 2015, 8:50 p.m.)
Review request for mesos, Gilbert Song and Timothy Chen.
Changes
-------
Style changes
Repository: mesos
Description
-------
Provides interface for verifying a blob of data for its digest and given digest type.
Diffs (updated)
-----
src/Makefile.am 2286366852b272c808490b6bd87ac9e894de57ac
src/slave/containerizer/provisioner/verifier/digest_verifier.hpp PRE-CREATION
src/tests/containerizer/provisioner_docker_tests.cpp 1b0c30450a07d01d1a38d460bc7d921c80be7e3b
Diff: https://reviews.apache.org/r/38654/diff/
Testing
-------
Thanks,
Jojy Varghese