You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@jclouds.apache.org by Timur Alperovich <no...@github.com> on 2015/07/08 01:42:04 UTC

[jclouds] Fix filtering of directories in the local blob store (#802)

The local blob store should not explicitly filter out directories. The changed behavior aligns the Transient blob store with Swift. However, the file system blob store does not have a notion of marker blobs and the second commit disables the directory test for the filesystem blob store.
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/802

-- Commit Summary --

  * LocalBlobStore: list marker blobs with delimiters.
  * Filesystem: disable directory integration test.

-- File Changes --

    M apis/filesystem/src/test/java/org/jclouds/filesystem/integration/FilesystemContainerIntegrationTest.java (6)
    M blobstore/src/main/java/org/jclouds/blobstore/config/LocalBlobStore.java (11)
    M blobstore/src/test/clojure/org/jclouds/blobstore2_test.clj (13)
    M blobstore/src/test/java/org/jclouds/blobstore/strategy/internal/ListContainerTest.java (15)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/802.patch
https://github.com/jclouds/jclouds/pull/802.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/802

Re: [jclouds] Fix filtering of directories in the local blob store (#802)

Posted by Timur Alperovich <no...@github.com>.

Sorry, I need to base this PR off the Swift subdirectory change as that's where the change to the ```testDirectory``` test happened. I can submit a different PR based off that branch.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/802#issuecomment-119378176

Re: [jclouds] Fix filtering of directories in the local blob store (#802)

Posted by Andrew Gaul <no...@github.com>.

Closed #802.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/802#event-350296146

Re: [jclouds] Fix filtering of directories in the local blob store (#802)

Posted by Andrew Gaul <no...@github.com>.

I see a failure:

```
  TransientContainerIntegrationTest>BaseContainerIntegrationTest.testDirectory:239 [[type=RELATIVE_PATH, id=null, name=directory, location=null, uri=null, userMetadata={}], [type=RELATIVE_PATH, id=null, name=directory/, location=null, uri=null, userMetadata={}]]
```

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/802#issuecomment-119377120

Re: [jclouds] Fix filtering of directories in the local blob store (#802)

Posted by Andrew Gaul <no...@github.com>.

Pushed to master as 669feb4d0c459b1612818869ce82b9b5d1915f42 and 5383148d9ef92fb39d8958abbe9cae19c80ca609.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/802#issuecomment-119391761