[jira] [Commented] (SLING-3255) StreamRendererServlet makes incorrect assumptions about BufferedInputStream

["Alexander Klimetschek (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-3255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13830512#comment-13830512 ] 

Alexander Klimetschek commented on SLING-3255:
----------------------------------------------

BTW, the tomcat servlet which was used as basis in SLING-1814 still seems to use the same code: [DefaultServlet.java copyRange() line 2045|http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/servlets/DefaultServlet.java?revision=1532296&view=markup#l2045]. 

> StreamRendererServlet makes incorrect assumptions about BufferedInputStream
> ---------------------------------------------------------------------------
>
>                 Key: SLING-3255
>                 URL: https://issues.apache.org/jira/browse/SLING-3255
>             Project: Sling
>          Issue Type: Bug
>          Components: Servlets
>    Affects Versions: Servlets Get 2.1.4
>            Reporter: Jukka Zitting
>            Assignee: Bertrand Delacretaz
>             Fix For: Servlets Get 2.1.6
>
>         Attachments: 0001-SLING-3255-StreamRendererServlet-makes-incorrect-ass.patch
>
>
> The class (with code apparently borrowed from Tomcat) assumes that BufferedInputStream.read(...) always fills the requested buffer, even if the BIS does not make such a guarantee.
> See OAK-956 for related discussion.



--
This message was sent by Atlassian JIRA
(v6.1#6144)